Skip to content

Fix: Make userinfo and scope management endpoints optional in Okta Key Manager #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Make userinfo and scope management endpoints optional in Okta Key Manager #1224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 11 additions & 27 deletions portals/admin/src/main/webapp/source/src/app/components/KeyManagers/AddEditKeyManager.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,6 @@ function AddEditKeyManager(props) {
case 'introspectionEndpoint':
case 'tokenEndpoint':
case 'revokeEndpoint':
case 'userInfoEndpoint':
case 'scopeManagementEndpoint':
if (fieldValue === '') {
error = intl.formatMessage({
id: 'KeyManagers.AddEditKeyManager.is.empty.error.key.config',
Expand Down Expand Up @@ -490,8 +488,6 @@ function AddEditKeyManager(props) {
|| hasErrors('tokenEndpoint', tokenEndpoint, validatingActive)
|| hasErrors('revokeEndpoint', revokeEndpoint, validatingActive)
|| hasErrors('enableDirectToken', enableDirectToken, validatingActive)
|| hasErrors('userInfoEndpoint', userInfoEndpoint, validatingActive)
|| hasErrors('scopeManagementEndpoint', scopeManagementEndpoint, validatingActive)
|| hasErrors('selectOrgs', validOrgs, validatingActive);
} else {
return hasErrors('name', name, validatingActive)
Expand Down Expand Up @@ -1256,21 +1252,16 @@ function AddEditKeyManager(props) {
margin='dense'
name='userInfoEndpoint'
label={(
<span>
<FormattedMessage
id='KeyManagers.AddEditKeyManager.form.userInfoEndpoint'
defaultMessage='UserInfo Endpoint'
/>
<StyledSpan>*</StyledSpan>
</span>
<FormattedMessage
id='KeyManagers.AddEditKeyManager.form.userInfoEndpoint'
defaultMessage='UserInfo Endpoint'
/>
)}
fullWidth
variant='outlined'
value={userInfoEndpoint}
onChange={onChange}
error={hasErrors('userInfoEndpoint', userInfoEndpoint, validating)}
helperText={hasErrors('userInfoEndpoint', userInfoEndpoint, validating)
|| intl.formatMessage({
helperText={intl.formatMessage({
id: 'KeyManagers.AddEditKeyManager.form.userInfoEndpoint.help',
defaultMessage: 'E.g., https://localhost:9443/oauth2/userInfo',
})}
Expand Down Expand Up @@ -1299,24 +1290,17 @@ function AddEditKeyManager(props) {
margin='dense'
name='scopeManagementEndpoint'
label={(
<span>
<FormattedMessage
id={'KeyManagers.AddEditKeyManager.'
+ 'form.scopeManagementEndpoint'}
defaultMessage='Scope Management Endpoint'
/>
<StyledSpan>*</StyledSpan>
</span>
<FormattedMessage
id={'KeyManagers.AddEditKeyManager.'
+ 'form.scopeManagementEndpoint'}
defaultMessage='Scope Management Endpoint'
/>
)}
fullWidth
variant='outlined'
value={scopeManagementEndpoint}
onChange={onChange}
error={hasErrors('scopeManagementEndpoint',
scopeManagementEndpoint, validating)}
helperText={hasErrors('scopeManagementEndpoint',
scopeManagementEndpoint, validating)
|| intl.formatMessage({
helperText={intl.formatMessage({
id: 'KeyManagers.AddEditKeyManager.form.scopeManagementEndpoint'
+ '.help',
defaultMessage: 'E.g, https://localhost:9443/oauth2/scope',
Expand Down
Loading