Add: Validation for Policy Upload #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasanthaS
requested changes
Mar 25, 2024
|
|
||
| const handleDrop = (policyDefinition: any) => { | ||
| setPolicyDefinitionFile(policyDefinition); | ||
| if(policyDefinition===null || policyDefinition===undefined) { |
Contributor
There was a problem hiding this comment.
And also this can be simplified as follows.
const handleDrop = (policyDefinition: any) => {
if (policyDefinition && policyDefinition[0] && (policyDefinition[0].name.endsWith('.j2') || policyDefinition[0].name.endsWith('.xml'))) {
setPolicyDefinitionFile(policyDefinition);
return;
}
APIMAlert.error(intl.formatMessage({
id: 'Uploading.Policies.Error',
defaultMessage: 'Incompatible file type',
}));
};
Contributor
Author
|
Will add the backend validation as backend does not return an error on adding an incompatible policy file |
Tharanidk
pushed a commit
to Tharanidk/apim-apps
that referenced
this pull request
Mar 27, 2024
Tharanidk
pushed a commit
to Tharanidk/apim-apps
that referenced
this pull request
Mar 27, 2024
…development iteration
Simplified the logic
BLasan
force-pushed
the
validate-policy-file-type
branch
from
307516d to
60ef32d
Compare
|
|
|
lasanthaS
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
.j2and.xmlFixes: wso2/api-manager#2663