Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIM 420] Porting fix for supporting throttling with custom throttling keys #11996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aka4rKO
Copy link

@aka4rKO aka4rKO commented May 3, 2023

Adding the functionality to use custom properties in the propertiesMap in addition to currently supported "apiContext, apiVersion, resourceKey, userId, appId, apiTenant, appTenant, clientIp" properties.

Related PR: https://github.com/wso2-support/carbon-apimgt/pull/4031
Issues: https://github.com/wso2-enterprise/financial-open-banking/issues/5583, https://github.com/wso2-enterprise/ob-compliance-toolkit-cds/issues/241

Note: Only a part of the above PR has been ported since the rest is already available in this branch #10692

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.38 ⚠️

Comparison is base (c7a4168) 48.39% compared to head (dd291b1) 48.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11996      +/-   ##
==========================================
- Coverage   48.39%   48.02%   -0.38%     
==========================================
  Files        1780     1780              
  Lines      127760   127765       +5     
  Branches    18280    18283       +3     
==========================================
- Hits        61835    61363     -472     
- Misses      58825    59327     +502     
+ Partials     7100     7075      -25     
Flag Coverage Δ
integration_tests 42.82% <20.00%> (-0.43%) ⬇️
unit_tests 20.96% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/gateway/handlers/throttling/ThrottleHandler.java 72.77% <20.00%> (-0.46%) ⬇️

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants