Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related fixes for PDFBox bump #12251

Open
wants to merge 1 commit into
base: 4.3.0-dependency-bumps
Choose a base branch
from

Conversation

DinithHerath
Copy link
Contributor

Purpose

Partially bumped pdfbox update for 3.0.1

Copy link
Contributor

@GihanAyesh GihanAyesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the features/apimgt/org.wso2.carbon.apimgt.rest.api.admin.feature/pom.xml file need to add the following entry to bundle the pack

org.wso2.orbit.org.apache.pdfbox:pdfbox-io:${pdfbox-io.version}

<dependency>
<groupId>org.apache.pdfbox</groupId>
<artifactId>pdfbox</artifactId>
</dependency>
<dependency>
<groupId>org.apache.pdfbox</groupId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groupId should be org.wso2.orbit.org.apache.pdfbox

@@ -1383,6 +1383,12 @@
<version>${pdfbox.version}</version>
</dependency>

<dependency>
<groupId>org.apache.pdfbox</groupId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groupid should be org.wso2.orbit.org.apache.pdfbox

@@ -2140,7 +2146,7 @@

<carbon.metrics.version>1.3.12</carbon.metrics.version>
<!-- apache pdfbox version -->
<pdfbox.version>2.0.25</pdfbox.version>
<pdfbox.version>3.0.1</pdfbox.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add a separate entry for pdfbox-io version (3.0.1.wso2v1) and change the imports accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants