Improve HTTP client with connection pool #7557
Conversation
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
...so2/carbon/identity/application/authentication/endpoint/util/AuthenticationEndpointUtil.java
Show resolved
Hide resolved
...o2/carbon/identity/application/authentication/endpoint/util/client/AuthAPIServiceClient.java
Show resolved
Hide resolved
...wso2.carbon.identity.core/src/main/java/org/wso2/carbon/identity/core/HTTPClientManager.java
Show resolved
Hide resolved
...wso2.carbon.identity.core/src/main/java/org/wso2/carbon/identity/core/HTTPClientManager.java
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/mgt/endpoint/util/IdentityManagementEndpointUtil.java
Show resolved
Hide resolved
...c/main/java/org/wso2/carbon/identity/mgt/endpoint/util/client/SelfRegistrationMgtClient.java
Show resolved
Hide resolved
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | Y | |
| #### Log Improvement Suggestion No: 3 | N | Already captured this info in previous step |
| #### Log Improvement Suggestion No: 5 | N | Already captured this info in previous step |
| #### Log Improvement Suggestion No: 6 | N | Already captured this info in previous step |
| #### Log Improvement Suggestion No: 7 | Y | |
| #### Log Improvement Suggestion No: 9 | N | Already captured this info in previous step |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (5.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #7557 +/- ##
============================================
- Coverage 50.88% 50.86% -0.03%
+ Complexity 18989 18984 -5
============================================
Files 2099 2100 +1
Lines 121742 121797 +55
Branches 25267 25274 +7
============================================
Hits 61952 61952
- Misses 51790 51841 +51
- Partials 8000 8004 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/18737567665
2 participants
Ref: wso2/product-is#24031
Following config will enable the http connection pool(default behaviour is false)