Add FAPI 2.0 configuration changes #7567
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces configuration support for FAPI compliance by adding a FAPI version setting and rendering it in the generated identity.xml.
- Add oauth.oidc.fapi.version default value in the server feature JSON.
- Emit in identity.xml.j2 when the version is configured.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/org.wso2.carbon.identity.core.server.feature.default.json | Adds the oauth.oidc.fapi.version default configuration key. |
| features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml.j2 | Renders the FAPIVersion element conditionally based on the configuration. |
...tity.core.server.feature/resources/org.wso2.carbon.identity.core.server.feature.default.json
Show resolved
Hide resolved
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7567 +/- ##
=========================================
Coverage 50.59% 50.60%
+ Complexity 19108 19084 -24
=========================================
Files 2094 2094
Lines 122677 122683 +6
Branches 25513 25515 +2
=========================================
+ Hits 62074 62081 +7
+ Misses 52633 52631 -2
- Partials 7970 7971 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configuration changes required for the FAPI 2.0 compliance to the identity.xml.j2 and default.json.
Issue: wso2/product-is#25863