Add slo support for multiple orgs #7583
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances organization-based authentication and logout handling by introducing deep copying of authenticator configurations and implementing support for multiple organization authenticators during logout flows.
- Adds a
deepCopymethod toAuthenticatorConfigfor creating deep copies using Java serialization - Implements organization authenticator tracking in
AuthenticationContextto handle multiple organization logins during logout - Refactors logout request handling to support iterating through organization-specific authenticators
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| DefaultStepHandler.java | Adds deep copy call for authenticator config in organization login flows to prevent shared state issues |
| DefaultLogoutRequestHandler.java | Implements special handling for "SSO" IDP logout with organization authenticator iteration logic |
| AuthenticationContext.java | Adds map to track organization authenticator configs and counter for current organization being processed |
| AuthenticatorConfig.java | Implements generic deep copy utility using Java object serialization |
| import org.wso2.carbon.identity.application.authentication.framework.model.AuthenticatedIdPData; | ||
| import org.wso2.carbon.identity.application.authentication.framework.model.AuthenticatedUser; | ||
| import org.wso2.carbon.identity.application.authentication.framework.model.AuthenticationResult; | ||
| import org.wso2.carbon.identity.application.authentication.framework.model.AuthenticationResult;xw |
There was a problem hiding this comment.
Remove the trailing 'xw' characters from the import statement.
| import org.wso2.carbon.identity.application.authentication.framework.model.AuthenticationResult;xw | |
| import org.wso2.carbon.identity.application.authentication.framework.model.AuthenticationResult; |
| public static <T extends Serializable> T deepCopy(T obj) { | ||
|
|
||
| try { | ||
| ByteArrayOutputStream bos = new ByteArrayOutputStream(); | ||
| ObjectOutputStream oos = new ObjectOutputStream(bos); | ||
| oos.writeObject(obj); | ||
| ByteArrayInputStream bis = new ByteArrayInputStream(bos.toByteArray()); | ||
| ObjectInputStream ois = new ObjectInputStream(bis); | ||
| return (T) ois.readObject(); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } |
There was a problem hiding this comment.
The deepCopy method does not close the streams (ObjectOutputStream and ObjectInputStream), which could lead to resource leaks. Wrap streams in try-with-resources blocks to ensure proper cleanup.
| this.tenantDomain = tenantDomain; | ||
| } | ||
|
|
||
| public static <T extends Serializable> T deepCopy(T obj) { |
There was a problem hiding this comment.
Missing docstring for the public method 'deepCopy'. All public methods should have a docstring explaining the purpose, parameters, return value, and potential exceptions.
| public Map<Integer, AuthenticatorConfig> getOrgAuthenticatorConfigs() { | ||
|
|
||
| return orgAuthenticatorConfigs; | ||
| } |
There was a problem hiding this comment.
Missing docstring for the public method 'getOrgAuthenticatorConfigs'. All public methods should have a docstring.
| public void addOrganicAuthenticatorConfig(int orgNumber, AuthenticatorConfig authenticatorConfig) { | ||
|
|
||
| this.orgAuthenticatorConfigs.put(orgNumber, authenticatorConfig); | ||
| } |
There was a problem hiding this comment.
Missing docstring for the public method 'addOrganicAuthenticatorConfig'. All public methods should have a docstring.
| public int getCurrentOrgNumber() { | ||
|
|
||
| return currentOrgNumber; | ||
| } |
There was a problem hiding this comment.
Missing docstring for the public method 'getCurrentOrgNumber'. All public methods should have a docstring.
| public void setCurrentOrgNumber(int currentOrgNumber) { | ||
|
|
||
| this.currentOrgNumber = currentOrgNumber; | ||
| } |
There was a problem hiding this comment.
Missing docstring for the public method 'setCurrentOrgNumber'. All public methods should have a docstring.
1 participant
Proposed changes in this pull request
sample fix for $Subject