-
Notifications
You must be signed in to change notification settings - Fork 684
Add operation scope modal. #4406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a68584 to
6435e1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new OperationScope model class to hold operation scope details with additional attributes, replacing the previous simple string-based scope representation. The changes enable more detailed scope validation by introducing boolean flags and structured scope information.
Key changes:
- Adds a new OperationScope model class with mandatory flag and scope string attributes
- Updates OperationScopeValidationContext to use OperationScope objects instead of simple strings
- Exports the new model package in the OSGi bundle
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| OperationScope.java | New model class with isMandatory boolean and scope string fields |
| OperationScopeValidationContext.java | Updates operationScopeMap to use OperationScope objects instead of strings |
| pom.xml | Adds org.wso2.carbon.context.model package to OSGi exports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/context/model/OperationScope.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public void setOperationScopeMap(Map<String, String> operationScopeMap) { | ||
| public void setOperationScopeMap(Map<String, OperationScope> operationScopeMap) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't we need a minor version bump since we are changing public methods here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpmadhavig WDYT?
|
PR builder started |
|
PR builder completed |
Purpose