Skip to content

Conversation

@Malith-19
Copy link

Purpose

  • $subject to introduce new attributes to the operation scope.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new OperationScope model class to hold operation scope details with additional attributes, replacing the previous simple string-based scope representation. The changes enable more detailed scope validation by introducing boolean flags and structured scope information.

Key changes:

  • Adds a new OperationScope model class with mandatory flag and scope string attributes
  • Updates OperationScopeValidationContext to use OperationScope objects instead of simple strings
  • Exports the new model package in the OSGi bundle

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
OperationScope.java New model class with isMandatory boolean and scope string fields
OperationScopeValidationContext.java Updates operationScopeMap to use OperationScope objects instead of strings
pom.xml Adds org.wso2.carbon.context.model package to OSGi exports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}

public void setOperationScopeMap(Map<String, String> operationScopeMap) {
public void setOperationScopeMap(Map<String, OperationScope> operationScopeMap) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we need a minor version bump since we are changing public methods here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpmadhavig WDYT?

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/18311555052

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/18311555052
Status: failure

@Malith-19 Malith-19 requested a review from ayshsandu October 8, 2025 04:31
@Malith-19 Malith-19 self-assigned this Oct 8, 2025
@Malith-19 Malith-19 merged commit 62bb62d into wso2:4.10.x Oct 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants