Add Java 21 compile time support #4433
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
| //NIO transport make use of this system property | ||
| System.setProperty("portOffset", portOffset); | ||
| //register carbon server confg as an OSGi service | ||
| registration = bundleContext.registerService(ServerConfigurationService.class.getName(), carbonServerConfiguration, null); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 3
Suggested change
| registration = bundleContext.registerService(ServerConfigurationService.class.getName(), carbonServerConfiguration, null); | |
| registration = bundleContext.registerService(ServerConfigurationService.class.getName(), carbonServerConfiguration, null); | |
| log.info("Carbon server configuration service registered successfully"); |
Comment on lines
52
to
+53
| System.setProperty("java.security.policy", resourcePath); | ||
| System.setSecurityManager(new SecurityManager()); | ||
| // System.setSecurityManager(new SecurityManager()); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 4
Suggested change
| System.setProperty("java.security.policy", resourcePath); | |
| System.setSecurityManager(new SecurityManager()); | |
| // System.setSecurityManager(new SecurityManager()); | |
| System.setProperty("java.security.policy", resourcePath); | |
| log.debug("Setting security policy from path: " + resourcePath); | |
| // System.setSecurityManager(new SecurityManager()); |
Comment on lines
+547
to
+548
| private void registerCarbonServlet(HttpContext defaultHttpContext) throws InvalidSyntaxException { | ||
|
|
There was a problem hiding this comment.
Log Improvement Suggestion No: 5
Suggested change
| private void registerCarbonServlet(HttpContext defaultHttpContext) throws InvalidSyntaxException { | |
| private void registerCarbonServlet(HttpContext defaultHttpContext) throws InvalidSyntaxException { | |
| log.info("Registering CarbonServlet with service path"); |
| carbonServletProperties.put("osgi.http.whiteboard.context.select", "(osgi.http.whiteboard.context.name=serviceContext)"); | ||
| ServiceRegistration<Servlet> servletServiceRegistration = | ||
| bundleContext.registerService(Servlet.class, carbonServlet, carbonServletProperties); | ||
| CarbonCoreDataHolder.getInstance().addServiceRegistration(servletServiceRegistration); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 6
Suggested change
| CarbonCoreDataHolder.getInstance().addServiceRegistration(servletServiceRegistration); | |
| CarbonCoreDataHolder.getInstance().addServiceRegistration(servletServiceRegistration); | |
| log.info("Successfully registered CarbonServlet at path: " + servicePath); |
| private static final Log log = LogFactory.getLog(CarbonCoreActivator.class); | ||
| private CarbonCoreDataHolder dataHolder = CarbonCoreDataHolder.getInstance(); | ||
|
|
||
| public void start(BundleContext context) throws Exception { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 7
Suggested change
| public void start(BundleContext context) throws Exception { | |
| public void start(BundleContext context) throws Exception { | |
| log.info("Starting Carbon Core bundle"); |
| // } | ||
| } | ||
|
|
||
| public void stop(BundleContext context) throws Exception { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 8
Suggested change
| public void stop(BundleContext context) throws Exception { | |
| public void stop(BundleContext context) throws Exception { | |
| log.info("Stopping Carbon Core bundle"); |
Comment on lines
+174
to
+177
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | ||
|
|
||
| serviceRegistrations.add(serviceRegistration); | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 9
Suggested change
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | |
| serviceRegistrations.add(serviceRegistration); | |
| } | |
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | |
| serviceRegistrations.add(serviceRegistration); | |
| if (log.isDebugEnabled()) { | |
| log.debug("Added service registration: " + serviceRegistration.getReference().getProperty("objectClass")); | |
| } |
Comment on lines
+179
to
+184
| public void unregisterServiceRegistrations() { | ||
|
|
||
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | ||
| serviceRegistration.unregister(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 10
Suggested change
| public void unregisterServiceRegistrations() { | |
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | |
| serviceRegistration.unregister(); | |
| } | |
| } | |
| public void unregisterServiceRegistrations() { | |
| log.info("Unregistering " + serviceRegistrations.size() + " service registrations"); | |
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | |
| serviceRegistration.unregister(); | |
| } |
Comment on lines
+89
to
90
| if (isMeteringEnabled) { | ||
| requestDataPersister = new RequestDataPersisterTask(); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 11
Suggested change
| if (isMeteringEnabled) { | |
| requestDataPersister = new RequestDataPersisterTask(); | |
| if (isMeteringEnabled) { | |
| log.info("Metering is enabled. Starting request data persister."); | |
| requestDataPersister = new RequestDataPersisterTask(); |
Comment on lines
53
to
55
| provider = (Provider) (Class.forName("org.bouncycastle.jce.provider.BouncyCastleProvider")). | ||
| getDeclaredConstructor().newInstance(); | ||
|
|
There was a problem hiding this comment.
Log Improvement Suggestion No: 12
Suggested change
| provider = (Provider) (Class.forName("org.bouncycastle.jce.provider.BouncyCastleProvider")). | |
| getDeclaredConstructor().newInstance(); | |
| provider = (Provider) (Class.forName("org.bouncycastle.jce.provider.BouncyCastleProvider")). | |
| getDeclaredConstructor().newInstance(); | |
| log.info("Successfully initialized BouncyCastle JCE provider"); |
Comment on lines
61
to
62
| } else { | ||
| throw new NoSuchProviderException("Configured JCE provider is not supported."); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 13
Suggested change
| } else { | |
| throw new NoSuchProviderException("Configured JCE provider is not supported."); | |
| } else { | |
| log.error("Unsupported JCE provider configured: " + providerName); | |
| throw new NoSuchProviderException("Configured JCE provider is not supported."); |
Comment on lines
171
to
+173
| } catch (Exception e) { | ||
| System.out.println("Exception occurred: " + e.getMessage()); | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 14
Suggested change
| } catch (Exception e) { | |
| System.out.println("Exception occurred: " + e.getMessage()); | |
| e.printStackTrace(); | |
| } catch (Exception e) { | |
| log.error("Failed to read custom keystore config for keystore: " + keyStoreName + ", config: " + configName + ". Error: " + e.getMessage()); | |
| System.out.println("Exception occurred: " + e.getMessage()); | |
| e.printStackTrace(); |
Comment on lines
+73
to
76
| //@Component(service = RegistryService.class) | ||
| public class EmbeddedRegistryService implements RegistryService { | ||
|
|
||
| private static final Log log = LogFactory.getLog(EmbeddedRegistryService.class); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 15
Suggested change
| //@Component(service = RegistryService.class) | |
| public class EmbeddedRegistryService implements RegistryService { | |
| private static final Log log = LogFactory.getLog(EmbeddedRegistryService.class); | |
| @Component(service = RegistryService.class) | |
| public class EmbeddedRegistryService implements RegistryService { | |
| private static final Log log = LogFactory.getLog(EmbeddedRegistryService.class); | |
| public EmbeddedRegistryService() { | |
| log.info("Initializing EmbeddedRegistryService"); | |
| } |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.