Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription Approval #1568

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Subscription Approval #1568

wants to merge 9 commits into from

Conversation

jhivandb
Copy link

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves:

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Nashaath
Nashaath reviewed Sep 23, 2024
View reviewed changes
en/docs/administer/configure-approval.md Outdated
@@ -0,0 +1,21 @@
# Configure Approval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be something along the lines of "Review Subscription Requests"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI mentioned here will handle any sort of review request. we've also got environment promotion requests here and will add more later. We could call it "Review Approval Requests"?

Nashaath
Nashaath reviewed Sep 23, 2024
View reviewed changes
en/docs/api-management/manage-api-traffic/configure-subscription-approval.md
@@ -0,0 +1,22 @@
# Configure Subscription Approval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be almost the same content we have drafted under the Administer section right (The page that will probably include info on the process to review subscription requests and proceed to approve or reject)?
Any reason to repeat the content here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page will be instructions specific to subscription approval.IDT we should mention that under Administer/Review ApprovalRequests same reasons as above

@jhivandb jhivandb marked this pull request as ready for review September 24, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashaath Nashaath Nashaath left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhivandb @Nashaath