Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingore regex pattern matching for inbound OAuth apps #7123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sahandilshan
Copy link
Contributor

@sahandilshan sahandilshan commented Nov 14, 2024

Purpose

$subject
To properly fix this, we have initially tried to do the regex pattern validation asynchronously with a webworker and kill the asyc task within a one second period if the regex pattern validation didn't complete. This is the best approach to do this. But when we try that we came up with several blockers where we couldn't use the async function inside the url-input component due to the way it was written. So we couldn't go with the above approach we mentioned. Therefore as a fix to this we are going to just ignore the regex pattern validation for inbound-oauth apps.
Create this wso2/product-is#21706 issue here to support the async validation for URLInput component.

Related Issues

@wso2-jenkins-bot
Copy link
Contributor

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.80%. Comparing base (cdd3bfb) to head (0aa67a3).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
modules/core/src/utils/url-utils.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7123      +/-   ##
==========================================
- Coverage   32.02%   31.80%   -0.23%     
==========================================
  Files          41       41              
  Lines         893      893              
  Branches      220      204      -16     
==========================================
- Hits          286      284       -2     
- Misses        557      609      +52     
+ Partials       50        0      -50     
Flag Coverage Δ
@wso2is/core 31.80% <75.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
modules/core/src/utils/url-utils.ts 23.40% <75.00%> (-4.26%) ⬇️

... and 13 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants