-
Notifications
You must be signed in to change notification settings - Fork 363
Add protobuf 3.25.8.wso2v1 version #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdds a new Maven POM that packages protobuf-java 3.25.8.wso2v1 as an OSGi bundle, exporting com.google.protobuf and google.protobuf packages, declaring an upstream dependency on com.google.protobuf:protobuf-java, and configuring WSO2 internal repositories and distribution management. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer / CI
participant Maven as Maven Build
participant Bundle as maven-bundle-plugin
participant Repo as WSO2 Nexus
Dev->>Maven: mvn deploy (project pom)
Note right of Maven `#DDEBF7`: Resolve dependencies\n(com.google.protobuf:protobuf-java)
Maven->>Bundle: run bundle plugin (generate OSGi manifest)
Note right of Bundle `#F6F8E6`: Set Bundle-SymbolicName,\nExport-Package, Import-Package
Bundle-->>Maven: attach bundle artifact
Maven->>Repo: deploy bundle to distributionManagement
Repo-->>Maven: store release/snapshot
Maven-->>Dev: build/deploy result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-11-10T05:22:00.232ZApplied to files:
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
protobuf-java/3.25.8.wso2v1/pom.xml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: piyumaldk
Repo: wso2/orbit PR: 1266
File: aws-core/2.30.22.wso2v2/pom.xml:180-183
Timestamp: 2025-11-10T05:22:00.232Z
Learning: In aws-core/2.30.22.wso2v2/pom.xml, the aws-query-protocol dependency is intentionally declared as a Maven dependency but not included in Export-Package or Embed-Dependency sections. This configuration has been tested and confirmed to work without requiring embedding or exporting.
📚 Learning: 2025-11-10T05:22:00.232Z
Learnt from: piyumaldk
Repo: wso2/orbit PR: 1266
File: aws-core/2.30.22.wso2v2/pom.xml:180-183
Timestamp: 2025-11-10T05:22:00.232Z
Learning: In aws-core/2.30.22.wso2v2/pom.xml, the aws-query-protocol dependency is intentionally declared as a Maven dependency but not included in Export-Package or Embed-Dependency sections. This configuration has been tested and confirmed to work without requiring embedding or exporting.
Applied to files:
protobuf-java/3.25.8.wso2v1/pom.xml
🔇 Additional comments (3)
protobuf-java/3.25.8.wso2v1/pom.xml (3)
93-96: Version configuration is correct.The protobuf.version (3.25.8) and export.pkg.protobuf.version (3.25.8.wso2v1) are properly configured per WSO2 Orbit conventions. The versions match the PR objective.
59-82: Dependency and export configuration looks good.The dependency on com.google.protobuf:protobuf-java is correctly declared, and the Export-Package configuration appropriately includes both com.google.protobuf.* and google.protobuf.* packages with correct version substitution.
33-57: Repository and distribution management configuration is appropriate.The POM is correctly configured to use WSO2 internal Maven repositories for both retrieval and deployment, with appropriate update policies. This aligns with WSO2 Orbit standards.
9680e13 to
6abf837
Compare
| <!-- | ||
| ~ Copyright (c) 2025, WSO2 LLC. (http://www.wso2.org) All Rights Reserved. | ||
| ~ | ||
| ~ WSO2 Inc. licenses this file to you under the Apache License, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be LLC
Purpose
This PR adds a new protobuf-java version for 3.25.8
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.