Skip to content

Conversation

@sgayangi
Copy link
Contributor

@sgayangi sgayangi commented Nov 26, 2025

Purpose

This PR adds a new protobuf-java version for 3.25.8

Summary by CodeRabbit

  • Chores
    • Added a new Google Protobuf 3.25.8.wso2v1 module packaged as an OSGi bundle, exporting protobuf packages and depending on protobuf-java.
    • Configured internal repository and distribution management for releases/snapshots to enable internal publishing and consumption.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Walkthrough

Adds a new Maven POM that packages protobuf-java 3.25.8.wso2v1 as an OSGi bundle, exporting com.google.protobuf and google.protobuf packages, declaring an upstream dependency on com.google.protobuf:protobuf-java, and configuring WSO2 internal repositories and distribution management.

Changes

Cohort / File(s) Summary
Protobuf-Java OSGi Bundle Configuration
protobuf-java/3.25.8.wso2v1/pom.xml
New Maven POM introducing a bundle-packaged artifact org.wso2.orbit.com.google.protobuf:protobuf-java:3.25.8.wso2v1. Adds properties protobuf.version and export.pkg.protobuf.version, dependency on com.google.protobuf:protobuf-java:${protobuf.version}, maven-bundle-plugin (v2.4.0) configuration with Bundle-SymbolicName/Name, Export-Package (com.google.protobuf., google.protobuf. with version), Import-Package: *;resolution:=optional, WSO2 repository and distributionManagement entries.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer / CI
    participant Maven as Maven Build
    participant Bundle as maven-bundle-plugin
    participant Repo as WSO2 Nexus

    Dev->>Maven: mvn deploy (project pom)
    Note right of Maven `#DDEBF7`: Resolve dependencies\n(com.google.protobuf:protobuf-java)
    Maven->>Bundle: run bundle plugin (generate OSGi manifest)
    Note right of Bundle `#F6F8E6`: Set Bundle-SymbolicName,\nExport-Package, Import-Package
    Bundle-->>Maven: attach bundle artifact
    Maven->>Repo: deploy bundle to distributionManagement
    Repo-->>Maven: store release/snapshot
    Maven-->>Dev: build/deploy result
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify OSGi export package names and version align with upstream package layout.
  • Confirm repository URLs and distributionManagement entries match internal publishing requirements.
  • Validate maven-bundle-plugin configuration and property values.

Poem

🐰 I nibbled bytes and wrapped them tight,
Protobuf bundles tucked for flight,
Exports neat, imports set to roam,
To WSO2 repo I carried them home. 🎀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete, providing only a minimal Purpose section while missing nearly all required template sections (Goals, Approach, User stories, Release note, Documentation, etc.). Complete the PR description using the provided template. Include Goals, Approach, Release note, Documentation, security checks, and other relevant sections to provide comprehensive context for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add protobuf 3.25.8.wso2v1 version' clearly and specifically summarizes the main change: adding a new protobuf version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9680e13 and 6abf837.

📒 Files selected for processing (1)
  • protobuf-java/3.25.8.wso2v1/pom.xml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: piyumaldk
Repo: wso2/orbit PR: 1266
File: aws-core/2.30.22.wso2v2/pom.xml:180-183
Timestamp: 2025-11-10T05:22:00.232Z
Learning: In aws-core/2.30.22.wso2v2/pom.xml, the aws-query-protocol dependency is intentionally declared as a Maven dependency but not included in Export-Package or Embed-Dependency sections. This configuration has been tested and confirmed to work without requiring embedding or exporting.
📚 Learning: 2025-11-10T05:22:00.232Z
Learnt from: piyumaldk
Repo: wso2/orbit PR: 1266
File: aws-core/2.30.22.wso2v2/pom.xml:180-183
Timestamp: 2025-11-10T05:22:00.232Z
Learning: In aws-core/2.30.22.wso2v2/pom.xml, the aws-query-protocol dependency is intentionally declared as a Maven dependency but not included in Export-Package or Embed-Dependency sections. This configuration has been tested and confirmed to work without requiring embedding or exporting.

Applied to files:

  • protobuf-java/3.25.8.wso2v1/pom.xml
🔇 Additional comments (2)
protobuf-java/3.25.8.wso2v1/pom.xml (2)

1-31: Metadata and license header look good; copyright year is correct.

The file structure, licensing, and project metadata are properly configured. The copyright year has been updated to 2025, addressing the previous review's concern.


33-66: Repository and dependency configuration is clean and follows WSO2 Orbit patterns.

The upstream dependency on com.google.protobuf:protobuf-java is properly declared without embedding, consistent with established Orbit patterns. Internal repository and distribution management endpoints are correctly configured.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c0c82a and 9680e13.

📒 Files selected for processing (1)
  • protobuf-java/3.25.8.wso2v1/pom.xml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: piyumaldk
Repo: wso2/orbit PR: 1266
File: aws-core/2.30.22.wso2v2/pom.xml:180-183
Timestamp: 2025-11-10T05:22:00.232Z
Learning: In aws-core/2.30.22.wso2v2/pom.xml, the aws-query-protocol dependency is intentionally declared as a Maven dependency but not included in Export-Package or Embed-Dependency sections. This configuration has been tested and confirmed to work without requiring embedding or exporting.
📚 Learning: 2025-11-10T05:22:00.232Z
Learnt from: piyumaldk
Repo: wso2/orbit PR: 1266
File: aws-core/2.30.22.wso2v2/pom.xml:180-183
Timestamp: 2025-11-10T05:22:00.232Z
Learning: In aws-core/2.30.22.wso2v2/pom.xml, the aws-query-protocol dependency is intentionally declared as a Maven dependency but not included in Export-Package or Embed-Dependency sections. This configuration has been tested and confirmed to work without requiring embedding or exporting.

Applied to files:

  • protobuf-java/3.25.8.wso2v1/pom.xml
🔇 Additional comments (3)
protobuf-java/3.25.8.wso2v1/pom.xml (3)

93-96: Version configuration is correct.

The protobuf.version (3.25.8) and export.pkg.protobuf.version (3.25.8.wso2v1) are properly configured per WSO2 Orbit conventions. The versions match the PR objective.


59-82: Dependency and export configuration looks good.

The dependency on com.google.protobuf:protobuf-java is correctly declared, and the Export-Package configuration appropriately includes both com.google.protobuf.* and google.protobuf.* packages with correct version substitution.


33-57: Repository and distribution management configuration is appropriate.

The POM is correctly configured to use WSO2 internal Maven repositories for both retrieval and deployment, with appropriate update policies. This aligns with WSO2 Orbit standards.

@sgayangi sgayangi force-pushed the protobuf-new-version branch from 9680e13 to 6abf837 Compare November 26, 2025 06:51
<!--
~ Copyright (c) 2025, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.
~
~ WSO2 Inc. licenses this file to you under the Apache License,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be LLC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants