Skip to content

Conversation

@Milanka00
Copy link
Contributor

@Milanka00 Milanka00 commented Sep 29, 2025

Purpose

This PR adds the missing configurations in current context.xml.j2 file. With this we can control the access to /carbon portal by adding following config in deployment.toml file.

[admin_console.control_access]
enable = true

Fixes wso2-enterprise/wso2-apim-internal/issues/4439
Fixes wso2/api-manager/issues/2169

Approach

Added existing and missing content to context.xml.j2 file by creating directories in both all-in-one-apim and api-control-plain (/resources/conf/templates/repository/conf/tomcat/carbon/META-INF/context.xml.j2) . Therefore, excluded the incoming context.xml.j2 files from bin.xml.

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.24%. Comparing base (59e3fae) to head (b439818).
⚠️ Report is 13 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (59e3fae) and HEAD (b439818). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (59e3fae) HEAD (b439818)
integration_tests 2 1
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13865       +/-   ##
=============================================
- Coverage     21.38%   11.24%   -10.15%     
+ Complexity     1296      751      -545     
=============================================
  Files           307      307               
  Lines         14803    14803               
  Branches       1586     1586               
=============================================
- Hits           3166     1664     -1502     
- Misses        11602    13123     +1521     
+ Partials         35       16       -19     
Flag Coverage Δ
integration_tests 11.24% <ø> (-10.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HeshanSudarshana HeshanSudarshana merged commit fa98c67 into wso2:master Oct 1, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[admin_console.control_access] configuration is not applied in the latest APIM 4.2.0

3 participants