-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component ID to API key identifier #3615
Conversation
04b9f86
to
7acb163
Compare
7acb163
to
6a53576
Compare
@@ -100,6 +101,7 @@ public void retrieveTokenFromRequestCtxTest_cached_validKey() throws APISecurity | |||
RequestContext.Builder requestContextBuilder = new RequestContext.Builder("/api-key"); | |||
requestContextBuilder.matchedAPI(new APIConfig.Builder("Petstore") | |||
.basePath("/test") | |||
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a uuid4 string
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2") | |
.uuid("64c33f14c2cf3616f59ecd8f") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used in the tests. Will remove these in a separate PR
@@ -70,6 +70,7 @@ public void retrieveTokenFromRequestCtxTest_invalidKey() { | |||
RequestContext.Builder requestContextBuilder = new RequestContext.Builder("/api-key"); | |||
requestContextBuilder.matchedAPI(new APIConfig.Builder("Petstore") | |||
.basePath("/test") | |||
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2") | |
.uuid("64c33f14c2cf3616f59ecd8f") |
@@ -131,6 +133,7 @@ public void retrieveTokenFromRequestCtxTest_validKey() throws APISecurityExcepti | |||
RequestContext.Builder requestContextBuilder = new RequestContext.Builder("/api-key"); | |||
requestContextBuilder.matchedAPI(new APIConfig.Builder("Petstore") | |||
.basePath("/test") | |||
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2") | |
.uuid("64c33f14c2cf3616f59ecd8f") |
[succeeded] : dev-deployment-v2 : 20241106.37 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241106.37 |
[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241106.37 |
[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241107.1 |
[] : dev-deployment-v2 : 20241107.1 |
[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241107.1 |
[succeeded] Controlplane cluster : stage-deployment-v2 : 20241107.4 |
[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241107.4 |
[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241107.4 |
[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241109.1 |
[] Controlplane cluster : prod-deployment-v2 : 20241109.1 |
[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20241109.1 |
[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241109.1 |
Purpose
$subject
Issues
Fixes #
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge