Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component ID to API key identifier #3615

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

mevan-karu
Copy link

Purpose

$subject

Issues

Fixes #

Automation tests

  • Unit tests added: Yes/No
  • Integration tests added: Yes/No

Tested environments

Not Tested


Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@mevan-karu mevan-karu changed the title Add API ID to API key identifier Add component ID to API key identifier Nov 6, 2024
@@ -100,6 +101,7 @@ public void retrieveTokenFromRequestCtxTest_cached_validKey() throws APISecurity
RequestContext.Builder requestContextBuilder = new RequestContext.Builder("/api-key");
requestContextBuilder.matchedAPI(new APIConfig.Builder("Petstore")
.basePath("/test")
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a uuid4 string

Suggested change
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2")
.uuid("64c33f14c2cf3616f59ecd8f")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used in the tests. Will remove these in a separate PR

@@ -70,6 +70,7 @@ public void retrieveTokenFromRequestCtxTest_invalidKey() {
RequestContext.Builder requestContextBuilder = new RequestContext.Builder("/api-key");
requestContextBuilder.matchedAPI(new APIConfig.Builder("Petstore")
.basePath("/test")
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2")
.uuid("64c33f14c2cf3616f59ecd8f")

@@ -131,6 +133,7 @@ public void retrieveTokenFromRequestCtxTest_validKey() throws APISecurityExcepti
RequestContext.Builder requestContextBuilder = new RequestContext.Builder("/api-key");
requestContextBuilder.matchedAPI(new APIConfig.Builder("Petstore")
.basePath("/test")
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.uuid("6003a3b7-af0f-4fb3-853e-a6562b2345f2")
.uuid("64c33f14c2cf3616f59ecd8f")

@VirajSalaka VirajSalaka merged commit cdb10a3 into wso2:choreo Nov 6, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20241106.37

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241106.37

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241106.37

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241107.1

@choreo-cicd
Copy link

[] : dev-deployment-v2 : 20241107.1

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241107.1

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20241107.4

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241107.4

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241107.4

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241109.1

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20241109.1

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20241109.1

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241109.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants