Skip to content

fix helper pane overflow from editor right when opened through toggle button #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

fix helper pane overflow from editor right when opened through toggle button #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dae197
fix helper pane overflow from editor right when opned through toggle …
senithkay Nov 25, 2025
f9923f4
Merge branch 'main' into fix-helper-pane-misalignment
kanushka Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...-panel/src/components/editors/MultiModeExpressionEditor/ChipExpressionEditor/CodeUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
getTokenTypeColor,
getChipDisplayContent
} from "./chipStyles";
import { HELPER_PANE_WIDTH } from "./constants";

export type TokenStream = number[];

Expand Down Expand Up @@ -443,7 +444,6 @@ export const buildOnFocusListner = (onTrigger: (cursor: CursorInfo) => void) =>
let relativeTop = coords.bottom - editorRect.top + 5;
let relativeLeft = coords.left - editorRect.left;

const HELPER_PANE_WIDTH = 300;
const editorWidth = editorRect.width;
const relativeRight = relativeLeft + HELPER_PANE_WIDTH;
const overflow = relativeRight - editorWidth;
Expand Down Expand Up @@ -477,7 +477,6 @@ export const buildOnSelectionChange = (onTrigger: (cursor: CursorInfo) => void)
let relativeTop = coords.bottom - editorRect.top + 5;
let relativeLeft = coords.left - editorRect.left;

const HELPER_PANE_WIDTH = 300;
const editorWidth = editorRect.width;
const relativeRight = relativeLeft + HELPER_PANE_WIDTH;
const overflow = relativeRight - editorWidth;
Expand Down Expand Up @@ -548,7 +547,6 @@ export const buildOnChangeListner = (onTrigeer: (newValue: string, cursor: Curso
let relativeTop = coords.bottom - editorRect.top + 5;
let relativeLeft = coords.left - editorRect.left;

const HELPER_PANE_WIDTH = 300;
const editorWidth = editorRect.width;
const relativeRight = relativeLeft + HELPER_PANE_WIDTH;
const overflow = relativeRight - editorWidth;
Expand Down
10 changes: 5 additions & 5 deletions ...ditors/MultiModeExpressionEditor/ChipExpressionEditor/components/ChipExpressionEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ import FXButton from "./FxButton";
import { HelperPaneToggleButton } from "./HelperPaneToggleButton";
import { HelperPane } from "./HelperPane";
import { listContinuationKeymap } from "../../../ExpandedEditor/utils/templateUtils";
import { HELPER_PANE_WIDTH } from "../constants";

type HelperPaneState = {
isOpen: boolean;
Expand Down Expand Up @@ -245,11 +246,10 @@ export const ChipExpressionEditorComponent = (props: ChipExpressionEditorCompone
let top = buttonRect.bottom - editorRect.top;
let left = buttonRect.left - editorRect.left;

// Add overflow correction for window boundaries
const HELPER_PANE_WIDTH = 300;
const viewportWidth = window.innerWidth;
const absoluteLeft = buttonRect.left;
const overflow = absoluteLeft + HELPER_PANE_WIDTH - viewportWidth;
// Add overflow correction for editor boundaries
const editorWidth = editorRect.width;
const relativeRight = left + HELPER_PANE_WIDTH;
const overflow = relativeRight - editorWidth;

if (overflow > 0) {
left -= overflow;
Expand Down
1 change: 1 addition & 0 deletions ...-panel/src/components/editors/MultiModeExpressionEditor/ChipExpressionEditor/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

export const CHIP_EXPRESSION_EDITOR_HEIGHT = 26;
export const EXPANDED_EDITOR_HEIGHT = 500;
export const HELPER_PANE_WIDTH = 300;

// Data attributes
export const DATA_CHIP_ATTRIBUTE = 'data-chip';
Expand Down
Loading