Skip to content

[BI Data Mapper] Fix crash when clear all mappings while in inside a focused view #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2025
+14 −11
Merged

[BI Data Mapper] Fix crash when clear all mappings while in inside a focused view #1020

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c723199
Implement reset functionality in DataMapperEditor component to handle…
KCSAbeywickrama Nov 29, 2025
7b4fede
Remove reset function implementation from DataMapperView
KCSAbeywickrama Nov 29, 2025
34ba47b
Update handleOnReset dependency array
KCSAbeywickrama Nov 29, 2025
7ed6cd3
Merge branch 'main' into bi-dm-infocus-clear-all-fix
KCSAbeywickrama Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions workspaces/ballerina/ballerina-visualizer/src/views/DataMapper/DataMapperView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,13 +558,6 @@ export function DataMapperView(props: DataMapperProps) {
await refreshDMModel();
};

const onDMReset = async () => {
await deleteMapping(
{ output: name, expression: undefined },
name
);
};

const onEdit = () => {
const context: VisualizerLocation = {
view: MACHINE_VIEW.BIDataMapperForm,
Expand Down Expand Up @@ -691,7 +684,6 @@ export function DataMapperView(props: DataMapperProps) {
reusable={reusable}
onClose={onDMClose}
onRefresh={onDMRefresh}
onReset={onDMReset}
onEdit={reusable ? onEdit : undefined}
applyModifications={updateExpression}
addArrayElement={addArrayElement}
Expand Down
16 changes: 14 additions & 2 deletions workspaces/ballerina/data-mapper/src/components/DataMapper/DataMapperEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ export function DataMapperEditor(props: DataMapperEditorProps) {
applyModifications,
onClose,
onRefresh,
onReset,
onEdit,
addArrayElement,
handleView,
Expand Down Expand Up @@ -191,6 +190,19 @@ export function DataMapperEditor(props: DataMapperEditorProps) {
dispatch({ type: ActionType.RESET_VIEW, payload: { view: newData } });
}, [resetSearchStore]);

const handleOnReset = useCallback(async () => {
const targetField = views[views.length - 1].targetField;
const outputIds = targetField.split('.');

let output: string;
while ((output = outputIds.pop()) === '0');

await deleteMapping(
{ output, expression: undefined },
targetField
);
}, [views, deleteMapping]);

useEffect(() => {
const lastView = views[views.length - 1];
handleView(lastView.targetField, !!lastView?.subMappingInfo);
Expand Down Expand Up @@ -335,7 +347,7 @@ export function DataMapperEditor(props: DataMapperEditorProps) {
onClose={handleOnClose}
onBack={handleOnBack}
onRefresh={onRefresh}
onReset={onReset}
onReset={handleOnReset}
onEdit={onEdit}
autoMapWithAI={autoMapWithAI}
undoRedoGroup={undoRedoGroup}
Expand Down
1 change: 0 additions & 1 deletion workspaces/ballerina/data-mapper/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ export interface DataMapperEditorProps {
goToFunction: (functionRange: LineRange) => Promise<void>;
enrichChildFields: (parentField: IOType) => Promise<void>;
onRefresh: () => Promise<void>;
onReset: () => Promise<void>;
onClose: () => void;
onEdit?: () => void;
handleView: (viewId: string, isSubMapping?: boolean) => void;
Expand Down
Loading