Skip to content

Allow underscores in function names #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

Allow underscores in function names #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions workspaces/ballerina/ballerina-visualizer/src/views/AIPanel/components/AIChat/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,12 @@ const AIChat: React.FC = () => {
case Command.DataMap: {
switch (parsedInput.templateId) {
case "mappings-for-records":
// TODO: Update this to use the LS API for validating function names
const invalidPattern = /[<>\/\(\)\{\}\[\]\\!@#$%^&*+=|;:'",.?`~]/;
if (invalidPattern.test(parsedInput.placeholderValues.functionName)) {
throw new Error("Please provide a valid function name without special characters.");
}

await processMappingParameters(
inputText,
{
Expand Down Expand Up @@ -1565,12 +1571,6 @@ const AIChat: React.FC = () => {

const functionName = parameters.functionName;

const invalidPattern = /[<>\/\(\)\{\}\[\]\\!@#$%^&*_+=|;:'",.?`~]/;

if (invalidPattern.test(functionName)) {
throw new Error("Please provide a valid function name without special characters.");
}

const projectImports = await rpcClient.getBIDiagramRpcClient().getAllImports();
const activeFile = await rpcClient.getAiPanelRpcClient().getActiveFile();
const projectComponents = await rpcClient.getBIDiagramRpcClient().getProjectComponents();
Expand Down
Loading