Add WSO2 integrator #901
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,12 +20,15 @@ import { assign, createMachine, interpret } from 'xstate'; | |
| import { activateProjectExplorer } from './project-explorer/activate'; | ||
| import { extension } from './biExtentionContext'; | ||
| import { fetchProjectInfo, ProjectInfo } from './utils'; | ||
| import { WI_EXTENSION_ID } from './constants'; | ||
| import * as vscode from 'vscode'; | ||
|
|
||
| interface MachineContext { | ||
| isBI: boolean; | ||
| isBallerinaPackage?: boolean; | ||
| isBallerinaWorkspace?: boolean; | ||
| isEmptyWorkspace?: boolean; | ||
| isInWI: boolean; | ||
| } | ||
|
|
||
| const stateMachine = createMachine<MachineContext>({ | ||
|
|
@@ -34,7 +37,8 @@ const stateMachine = createMachine<MachineContext>({ | |
| initial: 'initialize', | ||
| predictableActionArguments: true, | ||
| context: { | ||
| isBI: false, | ||
| isInWI: vscode.extensions.getExtension(WI_EXTENSION_ID) ? true : false | ||
| }, | ||
| states: { | ||
| initialize: { | ||
|
|
@@ -71,7 +75,8 @@ const stateMachine = createMachine<MachineContext>({ | |
| isBI: context.isBI, | ||
| isBallerinaPackage: context.isBallerinaPackage, | ||
| isBallerinaWorkspace: context.isBallerinaWorkspace, | ||
| isEmptyWorkspace: context.isEmptyWorkspace, | ||
| isInWI: context.isInWI | ||
| }); | ||
| } | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -324,14 +324,14 @@ const handlerFunction = handlerSourceFile.addFunction({ | |||||
| }] | ||||||
| }); | ||||||
| handleImportStatment(handlerSourceFile, 'vscode-messenger', 'Messenger'); | ||||||
| // Add statements to the function | ||||||
| const managerObject = `const rpcManger = new ${managerClassName}();` | ||||||
| handlerFunction.addStatements(managerObject); | ||||||
| typeMethods.forEach(value => { | ||||||
| handleMessengerTypes(handlerFunction, value, handlerSourceFile); | ||||||
| }) | ||||||
|
|
||||||
| console.log(`Adding handler function: ${headerComment}...`); | ||||||
|
Contributor
There was a problem hiding this comment. Fix incorrect variable in log message. The log message uses Apply this diff to fix the log message: -console.log(`Adding handler function: ${headerComment}...`);
+console.log(`Adding handler function: ${handlerName}...`);The 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| handleImportStatment(handlerSourceFile, './rpc-manager', managerClassName); | ||||||
|
|
||||||
| // Format imports into new lines | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,11 +4,11 @@ | |
| "description": "Generate rpc-manager,rpc-handler and rpc-client ts files in relevant libraries", | ||
| "main": "index.js", | ||
| "config": { | ||
| "CORE_RPC_TYPE_FILE": "main/index.ts", | ||
| "CORE_RPC_TYPE_DIR": "../../wi/wi-core/", | ||
| "EXT_RPC_MANAGER_DIR": "../../wi/wi-extension/", | ||
| "RPC_CLIENT_DIR": "../../wi/wi-rpc-client/", | ||
| "CORE_MODULE_NAME": "@wso2/wi-core" | ||
| }, | ||
| "scripts": { | ||
| "generate": "node index.js" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| const { spawnSync } = require('child_process'); | ||
|
|
||
| const isPreRelease = process.env.isPreRelease === 'true'; | ||
| const args = ['vsce', 'package', '--no-dependencies']; | ||
|
|
||
| if (isPreRelease) { | ||
| args.push('--pre-release'); | ||
| } | ||
|
|
||
| console.log(`Packaging VSIX with args: ${args.join(' ')}`); | ||
|
|
||
| const result = spawnSync('npx', args, { stdio: 'inherit' }); | ||
|
|
||
| if (result.error) { | ||
| console.error(`Failed to spawn vsce: ${result.error.message}`); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| if (result.status === null) { | ||
| console.error('vsce process was terminated by a signal'); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| process.exit(result.status); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,7 @@ | |
| "lint": "eslint src", | ||
| "test": "node ./out/test/runTest.js", | ||
| "build": "pnpm run compile && pnpm run lint && pnpm run postbuild", | ||
| "package": "node ../../common-libs/scripts/package-vsix.js", | ||
| "rebuild": "pnpm run clean && pnpm run compile && pnpm run postbuild", | ||
| "postbuild": "pnpm run package && pnpm run copyVSIX", | ||
| "copyVSIX": "copyfiles *.vsix ./vsix", | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify context variables
isBIProjectandisBallerinaProjectare properly registered and maintained.The visibility gating for testing view commands relies on context variables
isBIProjectandisBallerinaProject. These must be:Run the following script to locate and verify context variable management in the extension source:
Also applies to: 813-813
🏁 Script executed:
Length of output: 2522
I'll search for more context around these context variable setups to verify they're properly coordinated and maintained during workspace changes.
🏁 Script executed:
Length of output: 4664
🏁 Script executed:
Length of output: 3603
🏁 Script executed:
Length of output: 2071
🏁 Script executed:
Length of output: 14194
Verify and fix asymmetric context variable management for
isBallerinaProject.The context variables
isBIProjectandisBallerinaProjectare registered and maintained during extension lifecycle, but there's a critical asymmetry:isBIProjectis properly managed viasetBIContext(isBI)inworkspaces/ballerina/ballerina-extension/src/stateMachine.ts:1051, allowing it to reset tofalsewhen a workspace is not a BI project.isBallerinaProjectis set totrueinworkspaces/ballerina/ballerina-extension/src/core/extension.ts:2497viasetCurrentProject(), but is never reset tofalse.This one-way toggle breaks the visibility gating logic. Conditions like
"isBIProject || isBallerinaProject"will remaintrueeven after switching to a non-Ballerina workspace, defeating the PR's objective to properly hide/show items based on project type.Required: Add a corresponding mechanism to reset
isBallerinaProjecttofalsewhen the workspace is not a Ballerina project, mirroring the pattern used forisBIProject.🤖 Prompt for AI Agents