Fix helper pane overflow issue in popup #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces multi-project workspace support across the Ballerina extension ecosystem. Key changes include new workspace-aware interfaces (ProjectStructure, ProjectInfo, ProjectStructureResponse), a complete CodeMirror-based expression editor replacement, refactored AI code generation to handle multiple projects, and view hierarchy changes (Overview → PackageOverview, WorkspaceOverview). Support is added for workspace-level project metadata, dependency pull progress notifications, and project-specific migration reports. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Visualizer as Visualizer UI
participant StateMachine as State Machine
participant RPC as RPC Layer
participant LSP as Language Server
User->>Visualizer: Open Ballerina Workspace
Visualizer->>StateMachine: Initialize Context
StateMachine->>RPC: checkForProjects()
RPC->>LSP: Detect workspace/project structure
LSP-->>RPC: ProjectMetadata
RPC-->>StateMachine: ProjectMetadata (projectPath optional)
alt Is Workspace
StateMachine->>RPC: fetchProjectInfo(projectPath)
RPC->>LSP: getProjectInfo(ProjectInfoRequest)
LSP-->>RPC: ProjectInfo {projectKind: WORKSPACE_PROJECT, children[]}
RPC-->>StateMachine: ProjectInfo
StateMachine->>RPC: buildProjectsStructure(projectInfo)
RPC-->>StateMachine: ProjectStructureResponse {projects[]}
StateMachine->>Visualizer: Render WorkspaceOverview
else Is Package
StateMachine->>RPC: buildProjectsStructure(projectInfo)
RPC-->>StateMachine: ProjectStructureResponse
StateMachine->>Visualizer: Render PackageOverview
end
Visualizer->>Visualizer: Display Project/Workspace View
sequenceDiagram
participant Editor as Expression Editor
participant CodeMirror as CodeMirror
participant HelperPane as Helper Pane
participant LSP as Language Server
Editor->>CodeMirror: Initialize with ChipExpressionEditorComponent
CodeMirror->>CodeMirror: Apply chipPlugin, tokenField, completionPlugin
Editor->>Editor: User focuses editor
Editor->>LSP: buildOnFocusListner triggered
LSP-->>Editor: Compute cursor position (bounded to container)
Editor->>HelperPane: Position within editor bounds
Editor->>CodeMirror: User types/selects
CodeMirror->>Editor: Emit onChange with value
Editor->>LSP: Fetch completions/diagnostics
LSP-->>Editor: CompletionItems, Diagnostics
CodeMirror->>CodeMirror: Render autocompletion overlay (bounded)
Editor->>Editor: User selects completion
CodeMirror->>CodeMirror: Apply token decoration
Editor->>Editor: Update internal token state
Editor->>HelperPane: Sync helper pane (if open)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Areas requiring extra attention:
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kanushka
approved these changes
Nov 15, 2025
This was referenced Nov 17, 2025
73 tasks
This was referenced Nov 18, 2025
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR resolves a UI overflow issue in the Expression Editor where the helper pane extends outside the editor’s popup container.
Previously, the helper pane position was calculated relative to the window, causing it to overflow when the editor was rendered inside a constrained popup.
This fix ensures the helper pane remains fully visible within the editor boundary.
_Resolves: wso2/product-ballerina-integrator#1890
Goals
Approach
window.innerWidth.Summary by CodeRabbit
New Features
Chores