-
Notifications
You must be signed in to change notification settings - Fork 59
Fix expression editor completions, styles and recordConfigModel helper pane value selection #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expression editor completions, styles and recordConfigModel helper pane value selection #922
Conversation
|
Caution Review failedFailed to post review comments WalkthroughThis PR introduces multi-project workspace support, new project metadata structures, and a CodeMirror-based expression editor. Changes include new RPC APIs for project information and migration reporting, state machine refactoring to handle workspaceInfo and projectInfo, AI panel workflow updates, and comprehensive UI updates for workspace/package overviews. Changes
Sequence DiagramsequenceDiagram
participant User
participant Extension as VS Code Extension
participant StateMachine as State Machine
participant RPC as RPC Manager
participant LS as Language Server
User->>Extension: Open Ballerina Workspace
Extension->>StateMachine: checkForProjects()
StateMachine->>RPC: fetchProjectInfo(projectPath)
RPC->>LS: getProjectInfo(params)
LS-->>RPC: ProjectInfo {kind, name, children[]}
RPC-->>StateMachine: projectInfo
alt Multi-Project Workspace
StateMachine->>Extension: Display WorkspaceOverview
Extension->>Extension: Render PackageListView (all projects)
User->>Extension: Select Package
Extension->>StateMachine: setView(PackageOverview, projectPath)
else Single Project
StateMachine->>Extension: Display PackageOverview
end
alt AI Code Generation
User->>Extension: Generate/Repair Code
Extension->>RPC: getProjectSource(requestType)
RPC-->>Extension: ProjectSource[] {projectName, packagePath, isActive}
Extension->>Extension: flattenProjectToFiles(projects)
Extension->>LS: requestCodeGeneration(sourceFiles, updatedFileNames)
LS-->>Extension: PostProcessResponse {sourceFiles, diagnostics}
Extension->>Extension: Update Editor
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Areas requiring extra attention:
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Goals
Approach
Summary by CodeRabbit
New Features
Improvements
Chores