Skip to content

Conversation

@senithkay
Copy link
Contributor

Purpose

Creating configurables was not saving after submission.
The issue occurred because all fields in the form had their modified flag set to false by default.
While this is consistent with other forms, the configEditorV2/updateConfigVariable API sends empty text edits when all fields are marked as unmodified, causing the save to fail.

Resolves: wso2/product-ballerina-integrator#1959

Goals

  • Ensure configurables are correctly saved after submission.
  • Maintain consistent form behavior while addressing the API-specific requirement.
  • Avoid sending empty updates to the updateConfigVariable API.

Approach

  • Explicitly set the modified flag of the defaultValue property to true for newly created configurables.
  • This bypasses the empty text edits issue, allowing the API to process the submitted data correctly.
  • Other fields retain their default behavior, keeping form consistency across the application.

Note: If the Language Server is later updated to correctly handle unmodified fields, these explicit modified flag changes will become unnecessary and can be removed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kanushka kanushka merged commit 8f91eae into wso2:bi-1.5.x Nov 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants