Skip to content

Conversation

@senithkay
Copy link
Contributor

Purpose

The search fields inside the Helper Pane were not focusable, preventing users from typing or interacting with them.
This issue was caused by unnecessary event.preventDefault() and event.stopPropagation() calls, which blocked normal focus and click behavior within the pane.

Resolves: wso2/product-ballerina-integrator#1975

Goals

  • Allow search fields inside the Helper Pane to be properly focused and usable.
  • Restore expected click and focus behavior for interactive elements within the pane.
  • Remove outdated event handling logic that is no longer needed with the latest CodeMirror updates.

Approach

  • Removed the unnecessary event.preventDefault() and event.stopPropagation() calls applied to Helper Pane interactions.
  • These handlers were originally added for older expression editor behavior but now interfere with focus logic.
  • With the handlers removed, search fields and other clickable elements behave correctly without side effects.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kanushka kanushka merged commit 6334a41 into wso2:bi-1.5.x Nov 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants