-
Notifications
You must be signed in to change notification settings - Fork 59
Update plugin versions #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThese changes update the CAR plugin version constant from 5.4.11 to 5.4.12 and replace lexical string comparison with semantic version comparison to ensure correct version ordering during plugin version checks. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
workspaces/mi/mi-extension/src/util/templates.ts (1)
420-420: Consider using a constant for the synapse-unit-test-maven-plugin version.The version "5.4.12" is hardcoded here and matches the
LATEST_CAR_PLUGIN_VERSIONconstant defined at line 31. If these plugin versions should remain synchronized, consider using the same constant or creating a separate constant to avoid duplication and ensure consistency.If they should be synchronized, apply this diff:
<groupId>org.wso2.maven</groupId> <artifactId>synapse-unit-test-maven-plugin</artifactId> - <version>5.4.12</version> + <version>\${car.plugin.version}</version> <executions>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
workspaces/mi/mi-extension/src/util/onboardingUtils.ts(1 hunks)workspaces/mi/mi-extension/src/util/templates.ts(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
workspaces/mi/mi-extension/src/util/onboardingUtils.ts (1)
workspaces/mi/mi-extension/src/util/templates.ts (1)
LATEST_CAR_PLUGIN_VERSION(31-31)
🔇 Additional comments (1)
workspaces/mi/mi-extension/src/util/onboardingUtils.ts (1)
1491-1491: Excellent improvement to use semantic version comparison.Replacing lexical string comparison with
compareVersions()ensures correct version ordering (e.g., "5.4.9" < "5.4.11"), preventing potential bugs where version checks could fail due to string comparison semantics.
| }; | ||
|
|
||
| export const LATEST_CAR_PLUGIN_VERSION = "5.4.11"; | ||
| export const LATEST_CAR_PLUGIN_VERSION = "5.4.12"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify the plugin version exists in Maven repository.
The CAR plugin version has been updated to 5.4.12. Since this directly affects the generated POM files and plugin resolution, please confirm this version is available in the WSO2 Maven repository.
🏁 Script executed:
#!/bin/bash
# Verify that version 5.4.12 of vscode-car-plugin exists in WSO2 Maven repository
curl -s -o /dev/null -w "%{http_code}" "https://maven.wso2.org/nexus/content/groups/wso2-public/org/wso2/maven/vscode-car-plugin/5.4.12/vscode-car-plugin-5.4.12.pom"Length of output: 3
The 403 response is inconclusive—it doesn't definitively indicate whether the version exists. Let me search for additional information about this plugin version.
Let me search for more specific information about the 5.4.12 version release.
Version 5.4.12 does not appear to exist in any public Maven repository.
The verification confirms a critical issue: no evidence of vscode-car-plugin version 5.4.12 exists. The highest documented versions are 5.2.74 (vscode-car-plugin) and 5.2.99 (maven-car-plugin). The 403 response from the direct Maven repository check, combined with zero results across Maven Central, public repositories, and GitHub release history, indicates this version is unavailable. Using this non-existent version will cause Maven builds to fail with artifact resolution errors.
🤖 Prompt for AI Agents
In workspaces/mi/mi-extension/src/util/templates.ts at line 31, the constant
LATEST_CAR_PLUGIN_VERSION is set to "5.4.12" which does not exist and will break
Maven resolution; change the value to a known existing release (e.g., "5.2.74"
for vscode-car-plugin or "5.2.99" if you intend the maven-car-plugin), or make
the constant configurable with a safe fallback to a verified version, and update
any related docs/tests to match.
$subject
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.