Skip to content

Commit

Permalink
Clarify settings and purpose of Timing test
Browse files Browse the repository at this point in the history
  • Loading branch information
peteanderson80 committed Feb 14, 2021
1 parent 267e47e commit 3295d16
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,12 @@ Now (still from inside the docker container), run the unit tests:
./build/tests ~Timing
```

Assuming all tests pass, `sim_imgs` will now contain some test images rendered by the simulator. You may also wish to test the rendering frame rate. The following command will try to load all the Matterport environments into memory (requiring around 80 GB memory), and then some information about the rendering frame rate (at 640x480 resolution) will be printed to stdout:
Assuming all tests pass, `sim_imgs` will now contain some test images rendered by the simulator. You may also wish to test the rendering frame rate. The following command will try to load all the Matterport environments into memory (requiring around 50 GB memory), and then some information about the rendering frame rate (at 640x480 resolution, RGB outputs only) will be printed to stdout:
```
./build/tests Timing
```

The timing test must be run individually from the other tests to get accurate results. Refer to the [Catch](https://github.com/philsquared/Catch) documentation for unit test configuration options.
The timing test must be run individually from the other tests to get accurate results. Not that the Timing test will fail if there is insufficient memory. As long as all the other tests pass (i.e., `./build/tests ~Timing`) then the install is good. Refer to the [Catch](https://github.com/philsquared/Catch) documentation for unit test configuration options.

Now exit the docker container:
```
Expand Down
4 changes: 2 additions & 2 deletions src/test/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,8 @@ TEST_CASE( "Timing", "[Rendering]" ) {
sim.setCameraVFOV(radians(60)); // 60deg vfov, 80deg hfov
sim.setRenderingEnabled(true);
sim.setDiscretizedViewingAngles(true);
sim.setPreloadingEnabled(false);
int batchSize = 2;
sim.setPreloadingEnabled(true);
int batchSize = envs.size();
sim.setBatchSize(batchSize);
sim.setDepthEnabled(false);
REQUIRE_NOTHROW(sim.initialize());
Expand Down

0 comments on commit 3295d16

Please sign in to comment.