Skip to content

Fix TypeScript error in SVGVEleProps interface - add missing key property #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 17, 2025

Problem

The SVGVEleProps interface was missing the key property, causing TypeScript compilation errors when the SvgEle component was used in React map operations.

Error details:

src/svg/svgChart.tsx:212:41 - error TS2322: Type '{ key: string; node: SVGVNode; }' is not assignable to type 'SVGVEleProps'.
  Property 'key' does not exist on type 'SVGVEleProps'.

212       {children?.map((child) => <SvgEle key={child.key} node={child} />)}
                                            ~~~

Solution

Added the optional key?: string property to the SVGVEleProps interface to align with React's requirement for key props in mapped components.

Before:

interface SVGVEleProps {
  node: SVGVNode;
  touchStart?: any;
  touchMove?: any;
  touchEnd?: any;
}

After:

interface SVGVEleProps {
  node: SVGVNode;
  key?: string;
  touchStart?: any;
  touchMove?: any;
  touchEnd?: any;
}

Testing

  • ✅ TypeScript compilation now passes without errors (yarn typescript)
  • ✅ Build process completes successfully (yarn prepare)
  • ✅ No functional changes to component behavior
  • ✅ Maintains backwards compatibility

This is a minimal fix that resolves the type definition mismatch while preserving all existing functionality.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI changed the title [WIP] Find the type definition that needs to be modified and modify it Fix TypeScript error in SVGVEleProps interface - add missing key property Jul 17, 2025
@Copilot Copilot AI requested a review from zhiqingchen July 17, 2025 05:44
Copilot finished work on behalf of zhiqingchen July 17, 2025 05:44
@zhiqingchen zhiqingchen deleted the copilot/fix-686bdcaf-fd7b-482a-82d9-51cde060e0dc branch July 17, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants