Make requests Encodable-only instead of Codable #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
WPNRequestBase
and the generic parameterT
inWPNRequest<T>
fromCodable
toEncodable
only, reducing constraints on integrators.Changes Made
WPNRequestBase: Codable
toWPNRequestBase: Encodable
WPNRequest<T: Codable>
toWPNRequest<T: Encodable>
init(from decoder:)
method fromWPNRequest
classBenefits for Integrators
Before (required Codable):
After (only requires Encodable):
Rationale
Request objects are only encoded (sent to server), never decoded (received from server). Requiring
Codable
forced integrators to implement unnecessaryDecodable
conformance. This change:Codable
(which need both encoding and decoding)Fixes #71.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.