Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem with showing preselected databases when editing search #678

Closed
wants to merge 1 commit into from

Conversation

Lazy-poet
Copy link
Collaborator

This addresses issue #633

@ghost
Copy link

ghost commented Aug 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tadast
Copy link
Collaborator

tadast commented Aug 19, 2024

@Lazy-poet I gave this a test: when you complete a search and click "Edit search" i.e. hostname/?job_id= it gets into an infinite react update loop:

image

@Lazy-poet
Copy link
Collaborator Author

@Lazy-poet I gave this a test: when you complete a search and click "Edit search" i.e. hostname/?job_id= it gets into an infinite react update loop:

image

I believe there must've been numerous updates to that file since this PR was opened. I'll update the branch and fix the behavior accordingly

@Lazy-poet
Copy link
Collaborator Author

Lazy-poet commented Aug 19, 2024

Hi @tadast after reviewing, it appears like the issue this pr addresses has been resolved in one of the other prs after it so I'll proceed to close it

@Lazy-poet Lazy-poet closed this Aug 19, 2024
@Lazy-poet Lazy-poet deleted the issue/633 branch August 20, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants