Support connection load balancing #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client can pass 'loadBalance' parameter to enable or disable connection load balancing. Load balancing is provided by vertica server. Even if client enables and if it is turned OFF on server, driver should not fail.
| assert.ok conn.connected | ||
| assert.notEqual conn.redirctedHost, connectionInfo.host | ||
|
|
||
| done() |
Contributor
There was a problem hiding this comment.
done() should be placed to connection callback after assert
Contributor
|
@wvanbergen can you review this, please? Do these tests pass? |
Owner
|
I am not really in the best spot the review this code, because I have not worked with either node or vertica in a long time. If someone is interested in taking over maintainership of this library, let me know. |
Author
|
@Vanuan unfortunately I don't have access to vertica anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client can pass 'loadBalance' parameter to enable or disable
connection load balancing.
This should fix #27