Use XDG_DATA_HOME instead of HOME (if set)
#231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
reviewed
Jun 20, 2025
itchyny
reviewed
Jun 21, 2025
gore.go
Outdated
| baseDir = os.Getenv("XDG_DATA_HOME") | ||
|
|
||
| if baseDir != "" { | ||
| folderName = "gore" |
Collaborator
There was a problem hiding this comment.
I prefer returning filepath.Join(baseDir, "gore") here.
Contributor
Author
There was a problem hiding this comment.
Done. Please take a look when you can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will check if
XDG_DATA_HOMEis set and use it iffGORE_HOMEis not set already. If neither are set, it will fallback toHOME.LMK if I did something wrong and I’ll work to fix it. Thanks for reviewing my PR!
Closes #230.
💖