[Chunk Uploads + Enum Refactors] Improve Chunk upload speed + Refactor MemoryTypes and VkQueues #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/net/vulkanmod/vulkan/Drawer.java # src/main/java/net/vulkanmod/vulkan/framebuffer/SwapChain.java # src/main/java/net/vulkanmod/vulkan/memory/UniformBuffers.java
# Conflicts: # src/main/java/net/vulkanmod/render/VBO.java # src/main/java/net/vulkanmod/vulkan/memory/AutoIndexBuffer.java
|
Decided to close this as its outdated + causes crashes on Non-Resizable BAR GPUs if more than 256MB needs to be uploaded in a single frame (e.g. high res texture Packs) It also wasn't clear if this PR actually improved Chunk load speed, so will revisit + overhaul this code at a later time most likely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up significant boilerplate in several classes related to MemoryTypes + Queues, and replaces them with a much more readable and easier to use Enum-based system
This PR also corrects a mistake where cached system RAM was used instead of non-cached VRAM for Chunk uploads.
Which slightly improves the speed of chunk loading and saving.