Format amounts with sup fraction digits #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xMartin
force-pushed
the
format-amounts-with-sup-fraction-digits
branch
from
a7e1797 to
4147c1e
Compare
xMartin
force-pushed
the
format-amounts-with-sup-fraction-digits
branch
from
4147c1e to
7ff2c19
Compare
jancborchardt
approved these changes
May 31, 2023
Makes the fractional digits display like exponents. The idea to de-emphasize the fractional part without completely hiding it as it could be looking incorrect. And to make it look like prices are often being displayed in supermarkets and alike.
xMartin
force-pushed
the
format-amounts-with-sup-fraction-digits
branch
from
7ff2c19 to
e4bd937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had lots of discussions in the past about if and how to display fractional digits of amounts (#65). Never concluded about currency symbols and such.
This PR makes the fractional digits display like exponents. The idea to de-emphasize the fractional part without completely hiding it as it could be looking incorrect. And to make it look like prices are often being displayed in supermarkets and alike.