Fixes for low performance HA servers #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xZetsubou
reviewed
Feb 18, 2025
Co-authored-by: Bander <[email protected]>
Co-authored-by: Bander <[email protected]>
xZetsubou
reviewed
Feb 18, 2025
Co-authored-by: Bander <[email protected]>
|
Just FYI, yesterday in my home a source of 2.4GHz interference appeared, leading to high packet loss via WiFi connections. The interference is not continuous: there are some seconds pulses every some minutes. I'm logging calculated delays, if they are big: delta = (time.monotonic() - start) - HEARTBEAT_INTERVAL
if delta > (11-HEARTBEAT_INTERVAL):
self.info(f"Delta {delta} fails {fail_attempt}")
delta = max(0, min(delta, HEARTBEAT_INTERVAL))Here is extraction from my logs: "fails 0" means no timeout waiting for a response, even when the delay > 5 seconds. But, if it was not the introduced sleep time correction, some devices might close connections as not active. Now all work just fine! |
|
For me, it looks like finished. |
xZetsubou
pushed a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm yet to find time to update to HA Core 2025.x, and to incorporate your many changes to LocalTuya :(
Meanwhile, I ran many tests with low performance HA server, and, as the result, these are related fixes. I suggest to read commit by commit: they all should be understandable. Yes, I saw all the fixed misbehaviors in real life!
Yes, I saw successful connects after 4.5 seconds. But, regardless, making
TIMEOUT_CONNECT(was 3) less thanTIMEOUT_REPLYhas not much sense: usually connect is even longer process.I've changed
HEARTBEAT_INTERVALto 8.3 because 83 is a big enough prime number. Making periodic tasks with periods of prime numbers decrease the chance of "crowded" periodic events across the whole system.