Skip to content

Update to AppDaemon 4.5.2 to fix xaviml/controllerx#1184 #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 4, 2025

Conversation

charrus
Copy link
Contributor

@charrus charrus commented May 30, 2025

No description provided.

@charrus charrus changed the title Update too AppDaemon 4.5.2 to fix xaviml/controllerx#1184 Update to AppDaemon 4.5.2 to fix xaviml/controllerx#1184 May 30, 2025
@xaviml
Copy link
Owner

xaviml commented Jun 4, 2025

Hi @charrus,

Thank you for your PR. I have been testing it, and everything looks good on my setup. I also had to change something on the render_template, and found a bug in AppDaemon which I created a PR for.

If you don't mind, I will push my changes in your branch, on top of your commit.

Regards,
Xavi M.

@xaviml xaviml marked this pull request as ready for review June 4, 2025 23:05
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 98.85057% with 1 line in your changes missing coverage. Please review.

Project coverage is 95%. Comparing base (5c856f2) to head (694f27e).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
apps/controllerx/cx_core/controller.py 95% 1 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1188   +/-   ##
====================================
- Coverage    95%     95%   -0%     
====================================
  Files        65      65           
  Lines      2736    2734    -2     
====================================
- Hits       2592    2590    -2     
  Misses      144     144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xaviml xaviml merged commit f51765e into xaviml:main Jun 4, 2025
11 checks passed
@charrus charrus deleted the use_appdaemon_452 branch June 6, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants