add reordering to/from DIR_C with openMP #101
Conversation
|
Yes, exactly |
src/common.f90
Outdated
| integer, intent(out) :: dir_from, dir_to | ||
| integer, intent(in) :: rdr_dir | ||
|
|
||
| select case (rdr_dir) |
There was a problem hiding this comment.
What do you think about using findloc intrinsic in Fortran instead of the select case block? Haven't really experimented with this before but looks like we can use it to obtain dir_from and dir_to indices easily with a single query using the rdr_map array.
https://gcc.gnu.org/onlinedocs/gcc-12.3.0/gfortran/FINDLOC.html
There was a problem hiding this comment.
yeah, that's what I was wondering too. Performance wise I am not sure what's the best. The other option would be two lut for from_dir and to_dir of size 31 (with lots of zeros).
There was a problem hiding this comment.
You're right, it can be bad for performance, this one is called very often inside the reorder loop. Maybe its better to explore different options later when we're investigating the performance.
There was a problem hiding this comment.
actually, that call wasn't needed so I removed it. It should be better now performance wise, regardless of the implementation
|
I believe it is ready now |
add reordering to/from DIR_C with openMP
closes #100