Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media_url and media_key properties to CardsFetch #292

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add media_url and media_key properties to CardsFetch #292

wants to merge 2 commits into from

Conversation

boronine
Copy link

When fetching a WebsiteCard through the CardsFetch interface, I could not access media_key and media_url. This change fixes this.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tushdante
tushdante approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@tushdante tushdante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tushdante tushdante tushdante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boronine @CLAassistant @tushdante