Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(transform): csl_stencil canonicalization pass #2814

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Jul 2, 2024

Adds a canonicalisation pass for csl_stencil.apply. The op takes an empty tensor asiter_arg, which it does not manage itself. The conversion pass in #2803 initialises an iter_arg for each instance of apply. This canonicalisation pass identifies where this can be re-used, effectively removing redundant allocations.

@n-io n-io added minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio labels Jul 2, 2024
@n-io n-io self-assigned this Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (01640fc) to head (59a38f8).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2814      +/-   ##
==========================================
+ Coverage   89.82%   89.83%   +0.01%     
==========================================
  Files         396      398       +2     
  Lines       49055    49213     +158     
  Branches     7510     7552      +42     
==========================================
+ Hits        44063    44210     +147     
- Misses       3803     3808       +5     
- Partials     1189     1195       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io merged commit 7f09044 into main Jul 26, 2024
10 checks passed
@n-io n-io deleted the nicolai/csl-stencil-canonicalisation branch July 26, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants