transformations: (pdl) Better support for pdl.type and pdl.replace #3402
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3402 +/- ##
==========================================
+ Coverage 90.16% 90.17% +0.01%
==========================================
Files 455 455
Lines 57332 57394 +62
Branches 5511 5530 +19
==========================================
+ Hits 51692 51757 +65
+ Misses 4186 4184 -2
+ Partials 1454 1453 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Could you please split this into three mini PRs, and add unit tests for them? The filecheck tests I find are generally less useful for debugging, as they don't pinpoint the exact point of failure. In this case, the error might be that the matcher doesn't match, and then we would still need to search in the code for where things went wrong. In contrast, unit tests hopefully cover the core parts of functionality for each function, and will help locate the bug immediately.
| if pdl_op.constantType is None or pdl_op.constantType == xdsl_attr: | ||
| self.matching_context[ssa_val] = xdsl_attr | ||
| return True | ||
| else: | ||
| return False |
No description provided.