Add expand-copy pass that expands memref.copy as a nested structure o… #3452
+670
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielrodcanal
requested review from
superlopuh,
AntonLydike,
math-fehr and
PapyChacal
superlopuh
reviewed
Nov 14, 2024
|
|
||
| def apply(self, ctx: MLContext, op: builtin.ModuleOp) -> None: | ||
| expand_copy_pass = PatternRewriteWalker( | ||
| GreedyRewritePatternApplier([ExpandCopy()]), |
There was a problem hiding this comment.
I don't think there's a need for the greedy applier if it's just one rewrite
superlopuh
reviewed
Nov 14, 2024
| ) | ||
| for_indices.append(args[0]) | ||
|
|
||
| symbols = list(map(lambda dim: AffineExpr.dimension(dim), range(ndims))) |
There was a problem hiding this comment.
I'd recommend list/tuple comprehensions over map these days, they're noticeably faster
superlopuh
reviewed
Nov 14, 2024
…f affine for loops
Just latency estimation in terms of clock cycles. Strictly speaking I wouldn't need this pass to do that, but the tool I'm using works on the affine dialect, so it was easier writing this pass than changing the tool. |
|
Then I will apply your comments and include tests in the following days :) @superlopuh . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass that expands memref.copy as a nested structure of affine for loops with load/store. This is a functional port of the expand-copy pass in Google's HEIR: https://heir.dev/docs/passes/#-expand-copy.
Not sure if this is interesting for the community, but is something I needed for my own work. If it is, I will provide tests soon.