Skip to content

Version needs to be associated with Github releases #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

Version needs to be associated with Github releases #6

merged 2 commits into from
Mar 28, 2025

Conversation

juanpedromoreno
Copy link
Contributor

Based on what I understand from this error.

slemus9
slemus9 reviewed Mar 28, 2025
View reviewed changes
Copy link

@slemus9 slemus9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to the error, but I saw in the logs that it's trying to publish the sandboxJS module which contains an example of using florence. Should we set publish / skip := true in that module?

@juanpedromoreno
Copy link
Contributor Author

Great point @slemus9 ! Added those configs in ddda580

@juanpedromoreno juanpedromoreno merged commit 4f96b88 into main Mar 28, 2025
1 check passed
@juanpedromoreno juanpedromoreno deleted the no-version branch March 28, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slemus9 slemus9 slemus9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanpedromoreno @slemus9