Add musical notation #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kfxs wants to merge 66 commits into xenharmonic-devs:main from kfxs:add-musical-notation

kfxs commented Feb 6, 2025 •

edited

Loading

This PR, adds a staff notation widget on every tab.....

(for details, please refer to #852)

kfxs added 23 commits

January 30, 2025 20:16


          add vexflow and legacy scale-worshop-core; changes on url-endo and st…

02bb109

…ate.ts!


          ScoreView

96ee57b


          typo


          adapting my old legacy code to 3.1.0 version

58dae60


          revert my changes in url-encode.ts

f6e8c1b


          add ScoreView component to ScaleView

374eecf


          add Notation List to Scale State

7240a4a


          change name of notation to symbols

360c1f7


          adding default symbols with octave for the whole midi range

4c09ef0


          userNotation ref

380a374


          update App.vue using scale.symbols to push and pull scoreChord

3d7d99f


          get rid of unnecessary stuff!

8b0b667


          Show score widget in every tab

5ce91d4


          Better getSymbols funcition

af23b93


          Add ottava buttons


          fix bug

b200ab5


          Clear empty labels

77e8b8f


          Clear user notation btn


          Avoid undefine symbol

85e70fc


          Add error message

6ea86c6


          Change style

ce88737


          Remove unnecesary comments

836d4b2


          Remove empty space

99fc8de

frostburn reviewed

View reviewed changes

src/stores/state.ts Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/App.vue Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/App.vue Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/components/ScaleControls.vue Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/components/ScoreView.vue Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/components/ScoreView.vue Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/components/ScoreView.vue Outdated Show resolved Hide resolved

kfxs added 4 commits

February 21, 2025 15:17


          Add default method to scale symbols

7ef75e9


          Styles

1a11d25


          Formating

355e192


          Add warning message when note are beyond MIDI range.

a76ba7a

Author

kfxs commented Feb 21, 2025

You should probably show a warning when the number of symbols differs from scale size.

I added this warning:

Nevertheless, as a composer I would like to view also notes > NUMBER_OF_NOTES.
It would be nice to think on a solution for cases like this.

kfxs added 2 commits

February 21, 2025 22:07


          3.1.1

578ea6a


          Update CHANGELOG for v3.1.1

1d109ba

frostburn mentioned this pull request

Dynamic intervals beyond MIDI range #860

Open

kfxs added 5 commits

February 22, 2025 12:40


          Change vite.config.ts

b4ac121


          version 3.1.0-notation-preview

f9fb757


          Add swScaleVersion

4f38f98


          Add missing fields to JSON in case the scale is older

b460467


          Format

5a2c84a

frostburn reviewed

View reviewed changes

src/stores/__tests__/scale.spec.ts Outdated Show resolved Hide resolved

kfxs added 3 commits

February 23, 2025 19:05


          Add swScaleVersion to SERIALIZED

3fe91cd


          Test for scale.legacy.spec.ts

ebd0cc5


          Format

1dff112

frostburn reviewed

View reviewed changes

src/stores/__tests__/scale.legacy.spec.ts Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/stores/__tests__/scale.legacy.spec.ts Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/stores/__tests__/scale.legacy.spec.ts Outdated Show resolved Hide resolved

frostburn reviewed

View reviewed changes

src/stores/__tests__/scale.legacy.spec.ts Outdated Show resolved Hide resolved


          Remove scale.legacy.specs.ts

34cec9c

frostburn reviewed

View reviewed changes

vite.config.ts Outdated Show resolved Hide resolved

kfxs added 4 commits

February 24, 2025 09:55


          Revert changes in vite.config.ts

6b6d9ed


          Get version form utils.makeEnvelope

bbd61e7


          Make scoreChord computed

dfe059a


          Format

e435f33

frostburn reviewed

View reviewed changes

src/stores/scale.ts Outdated Show resolved Hide resolved

kfxs added 2 commits

February 24, 2025 14:36


          Get version directly from package.json

db67740


          Remove makeEnvelope form scale.ts

d7e44b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet