-
Notifications
You must be signed in to change notification settings - Fork 64
feat: upgrading sonatype central client #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: upgrading sonatype central client #583
Conversation
|
@xerial , a quick PR when you have time. Thanks! |
|
@xerial any updates on this PR? |
5a0c725 to
0caaa4c
Compare
|
@eed3si9n , would be great to get your review on this. It looks like the Sonatype Central api is down and so it's not possible to run tests against it. All bundle uploads are timing out currently (even with tests that used to succeed). I would prefer to test this manually against it to make sure it works before merging. |
| val sonatypeZapperClient = "1.3" | ||
| val sttp = "4.0.0-M16" | ||
| val sonatypeClient = "0.3.0" | ||
| val sonatypeClient = "0.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess anything that's built on JDK 8 would be a progress, but if each pull request takes two months to land, we might as well try to fix the timeout issue in one go?
|
Yea, if people are ok with it, I can actually start a library and maybe build this feature into sbt itself? |
The deadline is soon, so this would probably be the best course of action. Let me know if there is something I can do. |
|
@eed3si9n , I didn't think my initial PR to support sonatype central would ever get merged in this repo, so I started this sbt plugin a little less than a year ago. https://github.com/lumidion/sbt-sonatype-central. At the end of the day, the PR got merged here, so I didn't continue. The plugin just needs a little tinkering (lib updates and java 8 compat testing) and we could copy over the built-ins from sbt-ci-release and it should be enough. Bigger problem at the moment is that the sonatype central api itself seems to be having issues. I used the sonatype central library to upload packages over two weeks ago and it worked with no problem. Last week, the same lib couldn't upload any packages at all and users reported complete inability to upload anything here, as seen in this ticket: lumidion/sonatype-central-client#18. |
Potentially some of the reported timeout issue might be resolved if we increased the timeout? See also |
|
Thanks for working on it! We're all forced to migrate by the end of June unfortunately, this becomes a very important feature / PR. |
|
Here's a PR to add this to sbt 1.11.x - sbt/sbt#8126 |
Description
This PR adds the following:
/closes #564