Skip to content

Conversation

@Andrapyre
Copy link
Contributor

@Andrapyre Andrapyre commented Mar 3, 2025

Description

This PR adds the following:

  • support for publishing snapshot libraries to Sonatype Central.
  • Java 8 compatibility for the sonatype central client
  • logging for sonatype central status checks when the deployment hits a different status
  • revised status checks which stop after the deployment is validated rather than waiting until the deployment is published

/closes #564

@Andrapyre
Copy link
Contributor Author

@xerial , a quick PR when you have time. Thanks!

@chitralverma
Copy link

@xerial any updates on this PR?

@Andrapyre Andrapyre force-pushed the enabling-sonatype-central-snapshots branch from 5a0c725 to 0caaa4c Compare April 26, 2025 11:30
@Andrapyre Andrapyre changed the title feat: adding sonatype central snapshot support feat: upgrading sonatype central client Apr 26, 2025
@Andrapyre
Copy link
Contributor Author

@eed3si9n , would be great to get your review on this. It looks like the Sonatype Central api is down and so it's not possible to run tests against it. All bundle uploads are timing out currently (even with tests that used to succeed). I would prefer to test this manually against it to make sure it works before merging.

val sonatypeZapperClient = "1.3"
val sttp = "4.0.0-M16"
val sonatypeClient = "0.3.0"
val sonatypeClient = "0.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess anything that's built on JDK 8 would be a progress, but if each pull request takes two months to land, we might as well try to fix the timeout issue in one go?

@tgodzik
Copy link

tgodzik commented May 6, 2025

@eed3si9n should we migrate the repo to sbt organization if @xerial doesn't have the time to look at this?

@eed3si9n
Copy link
Contributor

eed3si9n commented May 6, 2025

Yea, if people are ok with it, I can actually start a library and maybe build this feature into sbt itself?

@tgodzik
Copy link

tgodzik commented May 6, 2025

Yea, if people are ok with it, I can actually start a library and maybe build this feature into sbt itself?

The deadline is soon, so this would probably be the best course of action. Let me know if there is something I can do.

@Andrapyre
Copy link
Contributor Author

@eed3si9n , I didn't think my initial PR to support sonatype central would ever get merged in this repo, so I started this sbt plugin a little less than a year ago. https://github.com/lumidion/sbt-sonatype-central. At the end of the day, the PR got merged here, so I didn't continue. The plugin just needs a little tinkering (lib updates and java 8 compat testing) and we could copy over the built-ins from sbt-ci-release and it should be enough. Bigger problem at the moment is that the sonatype central api itself seems to be having issues. I used the sonatype central library to upload packages over two weeks ago and it worked with no problem. Last week, the same lib couldn't upload any packages at all and users reported complete inability to upload anything here, as seen in this ticket: lumidion/sonatype-central-client#18.

@eed3si9n
Copy link
Contributor

eed3si9n commented May 7, 2025

Last week, the same lib couldn't upload any packages at all and users reported complete inability to upload anything here, as seen in this ticket: lumidion/sonatype-central-client#18.

Potentially some of the reported timeout issue might be resolved if we increased the timeout? See also
lumidion/sonatype-central-client#22. Either way, if you would like to get sbt-sonatype-central into JDK8-compat state, I'd be happy to go with that solution as well.

@pomadchin
Copy link

pomadchin commented May 8, 2025

Thanks for working on it! We're all forced to migrate by the end of June unfortunately, this becomes a very important feature / PR.

@eed3si9n
Copy link
Contributor

Here's a PR to add this to sbt 1.11.x - sbt/sbt#8126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support to publish snapshots to Central Sonatype

5 participants