-
Notifications
You must be signed in to change notification settings - Fork 64
Update slf4j-backend, upickle to 4.0.13 #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine dependency update for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the sttp dependency from a milestone release 4.0.0-M16 to the stable version 4.0.13. While this is a good update, I've raised a concern about potential binary incompatibilities with the sonatype-central-client-sttp-core dependency, which also relies on sttp. I've recommended verifying compatibility and potentially updating both dependencies together to prevent runtime issues.
| val airframe = "24.12.2" | ||
| val sonatypeZapperClient = "1.3" | ||
| val sttp = "4.0.0-M16" | ||
| val sttp = "4.0.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to sttp version 4.0.13 might cause issues. The project also depends on com.lumidion:sonatype-central-client-sttp-core:0.3.0 (via versions.sonatypeClient), which itself has a dependency on sttp.
If sonatype-central-client-sttp-core:0.3.0 was compiled against an older, binary-incompatible version of sttp (like the previous 4.0.0-M16), this update could lead to runtime errors such as NoSuchMethodError.
It is highly recommended to verify the sttp version compatibility of sonatype-central-client-sttp-core:0.3.0 or check if a newer version of sonatype-central-client should be used alongside this sttp update. Ideally, these related dependencies should be updated together to ensure compatibility.
About this PR
π¦ Updates
from
4.0.0-M16to4.0.13π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: