Skip to content

Conversation

@xerial-bot
Copy link
Collaborator

About this PR

πŸ“¦ Updates

from 24.12.2 to 2025.1.22 ⚠

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.wvlet.airframe" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.wvlet.airframe" }
}]
labels: library-update, early-semver-major, semver-spec-major, commit-count:1

@gemini-code-assist
Copy link

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the update of the airframe library dependencies, specifically airframe-http and airspec, to their latest version, "2025.1.22". This ensures the project benefits from the newest features, bug fixes, and performance improvements provided by the updated library, maintaining compatibility and leveraging the most current stable releases.

Highlights

  • Dependency Update: The airframe-http and airspec dependencies have been updated from version "24.12.2" to "2025.1.22". This is a major version update as indicated by the semver-spec-major label, suggesting potential breaking changes or significant new features.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Airframe dependencies to a new major version, 2025.1.22. This is a significant update that may introduce breaking changes. I've identified a potential build-breaking change in the usage of airframe-http's client builder in SonatypeClient.scala. Please ensure the project compiles and all tests pass before merging.

val versions = new {
val scala = "2.12.20" // Must use Scala 2.12.x for sbt plugins
val airframe = "24.12.2"
val airframe = "2025.1.22"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This major version upgrade for Airframe likely introduces breaking API changes.

The method Http.client.withBackend used in src/main/scala/xerial/sbt/sonatype/SonatypeClient.scala (line 47) was likely removed in this new version. The @nowarn annotation on line 40 of that file indicates it was already deprecated.

The replacement is probably withClientBackend. Please update the code in SonatypeClient.scala accordingly:

// src/main/scala/xerial/sbt/sonatype/SonatypeClient.scala:47
.withClientBackend(URLConnectionClientBackend)

This is a critical issue that will likely break the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants