-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial sphinx-gallery #609
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 62 62
Lines 4735 4735
=======================================
Hits 4415 4415
Misses 320 320 ☔ View full report in Codecov by Sentry. |
Looks great @maximelucas!! Only comment is that I would remove the "Gallery" tab and examples and remove the "Algorithms" subsection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only comment is wow there are a lot of files --- how does this compare to other libraries?
Thanks Nich! Most of the files were autogenerated, I removed them. Also for the record I only needed to:
Basically that's it. And to add new examples, we just need to add single I put the Gallery visible in the menu too (moved away from dropdown). If you like it I'll merge. |
Looks great! When you merge this PR, can you open an issue to add in some more examples and can you also make sure that the unused pictures and files from the old gallery are deleted? |
Addressing #583: initial try for a new gallery that's automatically generated from individual small python scripts.
Right now it's accessible through a new item "Gallery of examples" in the menu. I think it could ultimately be merged with our current Gallery by porting the existing plots into this new format.
Let me know if you like it, and we can see what to add (now or later).