ci: Set MACOSX_DEPLOYMENT_TARGET to 10.10 for x86_64, 11.0 for arm64#3253
Merged
lu-zero merged 1 commit intoxiph:masterfrom Sep 24, 2023
Merged
ci: Set MACOSX_DEPLOYMENT_TARGET to 10.10 for x86_64, 11.0 for arm64#3253lu-zero merged 1 commit intoxiph:masterfrom
lu-zero merged 1 commit intoxiph:masterfrom
Conversation
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
lu-zero
approved these changes
Sep 12, 2023
Collaborator
lu-zero
left a comment
lu-zero
left a comment
There was a problem hiding this comment.
The change is good, clippy seems overzealous today.
Contributor
Author
|
I'll rebase off of master to re-run the actions. (edit: actually, I am even with master so I'll just amend the commit). |
fdintino
force-pushed
the
ci/macosx-deployment-target
branch
from
234ab3d to
923e5a6
Compare
lu-zero
force-pushed
the
ci/macosx-deployment-target
branch
from
923e5a6 to
958e083
Compare
Collaborator
|
Let see if the auto-rebase works as intended. I eventually fixed the CI, hopefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that rav1e is compiling against the OS X 12 SDK, whereas the binaries I distribute for pillow-avif-plugin target 10.10 and 11 for x86_64 and arm64, respectively—which is pretty common practice for python wheels. I've confirmed that cargo-c respects the
MACOSX_DEPLOYMENT_TARGETenvironment variable and that the artifacts are in fact built against the desired SDKs.