Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized diff iterator #3262

Closed
wants to merge 4 commits into from
Closed

Optimized diff iterator #3262

wants to merge 4 commits into from

Conversation

kornelski
Copy link
Contributor

Hoisted checks that before the loop

@kornelski
Copy link
Contributor Author

It looks like the libdav1d hack with an upgrade-in-place to Ubuntu Lunar doesn't work any more, and it won't upgrade libc6.

@kornelski kornelski closed this Oct 4, 2023
@lu-zero
Copy link
Collaborator

lu-zero commented Oct 4, 2023

the set doesn't seem bad though.

@kornelski
Copy link
Contributor Author

What do you mean?

@kornelski kornelski reopened this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/context/block_unit.rs 93.71% <100.00%> (-0.01%) ⬇️
src/context/mod.rs 91.00% <100.00%> (-0.09%) ⬇️
src/context/transform_unit.rs 89.78% <100.00%> (ø)
src/encoder.rs 86.89% <81.81%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@kornelski
Copy link
Contributor Author

Included in #3261

@kornelski kornelski closed this Oct 9, 2023
@kornelski kornelski deleted the diff-opt branch October 9, 2023 13:02
@kornelski kornelski mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kornelski @lu-zero