Move WHT inverse transforms to common lookup table for x86_64 and aarch64#3274
Merged
barrbrain merged 3 commits intoxiph:masterfrom Oct 25, 2023
Merged
Move WHT inverse transforms to common lookup table for x86_64 and aarch64#3274barrbrain merged 3 commits intoxiph:masterfrom
x86_64 and aarch64#3274barrbrain merged 3 commits intoxiph:masterfrom
Conversation
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
barrbrain
force-pushed
the
lossless
branch
4 times, most recently
from
7738eb0 to
3dcd1a7
Compare
lu-zero
approved these changes
Oct 25, 2023
Collaborator
lu-zero
left a comment
lu-zero
left a comment
There was a problem hiding this comment.
Seems nice, I'm unsure if implementing IndexMut would make the code even simpler, but since it is used only in macros, I guess won't change much the end result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TxSizeandTxTypeas array indices.WHT_WHTimplementations.WHT_WHTwith table lookup foraarch64andx86_64.Note: The
x86_64table generation code is getting unwieldy.