Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WHT inverse transforms to common lookup table for x86_64 and aarch64 #3274

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Move WHT inverse transforms to common lookup table for x86_64 and aarch64 #3274

merged 3 commits into from
Oct 25, 2023

Conversation

barrbrain
Copy link
Collaborator

  • Explicitly elide bounds checks for TxSize and TxType as array indices.
  • Expand transform function tables to make room for WHT_WHT implementations.
  • Replace branch for WHT_WHT with table lookup for aarch64 and x86_64.

Note: The x86_64 table generation code is getting unwieldy.

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/asm/shared/transform/inverse.rs 100.00% <100.00%> (ø)
src/asm/shared/transform/mod.rs 100.00% <100.00%> (ø)
src/asm/x86/transform/inverse.rs 65.07% <12.00%> (-34.93%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@barrbrain barrbrain force-pushed the lossless branch 4 times, most recently from 7738eb0 to 3dcd1a7 Compare October 25, 2023 10:51
lu-zero
lu-zero approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice, I'm unsure if implementing IndexMut would make the code even simpler, but since it is used only in macros, I guess won't change much the end result.

@barrbrain barrbrain merged commit 3d43eca into xiph:master Oct 25, 2023
23 of 25 checks passed
@barrbrain barrbrain deleted the lossless branch October 25, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barrbrain @lu-zero