Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable eslint-plugin-promise #656

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Re-enable eslint-plugin-promise #656

merged 3 commits into from
Jul 13, 2024

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Mar 23, 2022

Disabled in dddc991

@fisker
Copy link
Contributor Author

fisker commented Mar 23, 2022

Didn't see dddc991#r67879026, feel free to close if you don't want to enable it.

@sindresorhus
Copy link
Member

I'll think about it. We can keep this open for now.

@fregante
Copy link
Member

fregante commented Jul 20, 2023 •
edited
Loading

Didn't see dddc991#r67879026

v6 supports it:

@lishaduck lishaduck mentioned this pull request Jun 23, 2024
Closed
@fregante fregante linked an issue Jul 13, 2024 that may be closed by this pull request
Re-enable eslint-plugin-promise as it now supports ESLint 8 #699
Closed
@fregante
Copy link
Member

Might be a good time to close it or merge it 🙏

@sindresorhus sindresorhus merged commit b168f08 into xojs:main Jul 13, 2024
2 checks passed
@fisker fisker deleted the eslint-plugin-promise branch July 14, 2024 02:56
@matrix-compute matrix-compute mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable eslint-plugin-promise as it now supports ESLint 8
3 participants
@fisker @sindresorhus @fregante