-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Lazy_import not return None in a shared python env that contains cuda-related files on a cpu-only machine #50
Open
ChengjieLi28
wants to merge
9
commits into
xorbitsai:main
Choose a base branch
from
ChengjieLi28:bug/detect_card_in_lazy_import
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 89.00% 89.10% +0.10%
==========================================
Files 47 47
Lines 3991 3991
Branches 760 760
==========================================
+ Hits 3552 3556 +4
+ Misses 356 350 -6
- Partials 83 85 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
aresnow1
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ChengjieLi28
force-pushed
the
bug/detect_card_in_lazy_import
branch
from
August 3, 2023 09:14
3ebaa68
to
c318f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related xorbitsai/xorbits#595
Check code requirements