-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fury as an optional serializer #78
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 89.12% 88.98% -0.15%
==========================================
Files 48 48
Lines 4010 4012 +2
Branches 764 764
==========================================
- Hits 3574 3570 -4
- Misses 351 356 +5
- Partials 85 86 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
|
||
def register_classes(*args): | ||
def register_class_to_fury(obj_type): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only register class for current thread, fury in other threads doens't get registerd. The deserialization may raise error if the register are not consisitent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the root cause of random crash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, another issue tis that the class register order must be consistent between serializatio and deserialization.
Is class registration constsitent always? Could you print all class registration too.
Is there any things I can help for this PR? |
fury Python is hard to use, could you help fix the crash issue? |
What do these changes do?
Related issue number
This test code may be crash when fury deserializing, but if it does not crash, the performance is better than Mars default serializers.
Use fury(if not crash): 9.764425039291382
Mars default: 13.590802669525146
Fixes #xxxx
Check code requirements